Bug 1380923

Summary:	sign-file script: unrecognized character
Product:	[Fedora] Fedora	Reporter:	Pavel Valena <pvalena>
Component:	kernel	Assignee:	Kernel Maintainer List <kernel-maint>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	23	CC:	gansalmon, ichavero, itamar, jonathan, kernel-maint, madhu.chinakonda, mchehab
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-01 15:28:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Pavel Valena 2016-10-01 14:56:06 UTC

Description of problem:
I followed a guide for signing kernel modules

https://docs.fedoraproject.org/en-US/Fedora/23/html/System_Administrators_Guide/sect-signing-kernel-module-with-the-private-key.html

and the sign-file script fails with an error.
 

Version-Release number of selected component (if applicable):
kernel-devel-4.7.4-100.fc23.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. You need a key pair
https://docs.fedoraproject.org/en-US/Fedora/23/html/System_Administrators_Guide/sect-generating-a-public-private-x509-key-pair.html

and an unsigned module- I have used the VirtualBox module from rpmfusion 
http://rpmfusion.org/Howto/VirtualBox

2. # perl /usr/src/kernels/4.7.4-100.fc23.x86_64/scripts/sign-file sha256 private_key.priv public_key.der /usr/lib/modules/4.7.4-100.fc23.x86_64/extra/VirtualBox/vboxdrv.ko

Actual results:
Unrecognized character \x7F; marked by <-- HERE after <-- HERE near column 1 at /usr/src/kernels/4.7.4-100.fc23.x86_64/scripts/sign-file line 1.

Expected results:
The module gets signed.

Additional info:
I have reported a bug on the documentation https://bugzilla.redhat.com/show_bug.cgi?id=1379758.

Comment 1 Josh Boyer 2016-10-01 15:28:28 UTC

sign-file isn't a perl script any longer.  It was changed to a compiled C application some time ago.  The documentation is out of date.

Closing as this isn't a kernel problem.

Comment 2 Pavel Valena 2016-10-01 15:48:51 UTC

Thank you!