Bug 1381312

Summary: non-descriptive error message when trying to create a vm from template that resides on an inactive SD
Product: Red Hat CloudForms Management Engine Reporter: luke couzens <lcouzens>
Component: ProvisioningAssignee: Piotr Kliczewski <pkliczew>
Status: CLOSED NOTABUG QA Contact: luke couzens <lcouzens>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 5.7.0CC: abellott, amureini, dajohnso, jhardy, lcouzens, michal.skrivanek, obarenbo
Target Milestone: GA   
Target Release: cfme-future   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:rhev:provision
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-28 13:31:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: RHEVM Target Upstream Version:
Attachments:
Description Flags
Request screen showing error
none
request screen none

Description luke couzens 2016-10-03 16:23:07 UTC
Created attachment 1206929 [details]
Request screen showing error

Description of problem:Provisioning instances on rhevm results in error.


Version-Release number of selected component (if applicable):5.7.0.3


How reproducible:100%


Steps to Reproduce:
1.provision configured appliance
2.add rhevm provider
3.try to provision instance

Actual results:Instance fails with error


Expected results:Instance is provisioned successfully


Additional info:
last message on request page after refresh shows

[EVM] VM [lcouz_test] Step [CheckProvisioned] Status [Creating VM] Message [Creating VM] Current Retry Number [1]

Comment 2 luke couzens 2016-10-03 17:01:10 UTC
After further investigation it seems that this might be down to the providers  template data store. (rhevm36_iscsi_data - Inactive) I assume this means the rhel65 template is currently unusable. 

Tho this maybe the case should we see this error (rhevm36_iscsi_data - Inactive) or similar in CFME request page.

Also I uploaded the wrong screenshot before see additional one.

Comment 3 luke couzens 2016-10-03 17:01:32 UTC
Created attachment 1206932 [details]
request screen

Comment 4 Nick Carboni 2016-10-03 20:45:53 UTC
I think this should be a Provisioning bug. Changing component.

Comment 5 Oved Ourfali 2016-10-05 14:11:27 UTC
Changing the title and severity to reflect the real use-case, based on your latest comment.
Also, is the target storage domain active?

Can you attach logs on both ends?

Comment 6 Piotr Kliczewski 2016-10-05 14:47:11 UTC
please attach cfme and rhv logs.

Comment 9 luke couzens 2016-10-06 14:21:43 UTC
piotr, I am using Version 3.6.9.2-0.1.el6

Comment 10 Piotr Kliczewski 2016-10-06 14:41:22 UTC
Michal, Was this issue fixed or we have new engine side issue?


2016-10-06 06:51:52,710 ERROR [org.ovirt.engine.core.bll.AddVmFromTemplateCommand] (ajp-/127.0.0.1:8702-2) [16f4abbf] Error during CanDoActionFailure.: java.lang.NullPointerException
        at org.ovirt.engine.core.bll.ImagesHandler.findDomainsInApplicableStatusForDisks(ImagesHandler.java:490) [bll.jar:]
        at org.ovirt.engine.core.bll.AddVmFromTemplateCommand.verifySourceDomains(AddVmFromTemplateCommand.java:194) [bll.jar:]
        at org.ovirt.engine.core.bll.AddVmCommand.canDoAction(AddVmCommand.java:537) [bll.jar:]
        at org.ovirt.engine.core.bll.AddVmFromTemplateCommand.canDoAction(AddVmFromTemplateCommand.java:157) [bll.jar:]

Comment 11 Michal Skrivanek 2016-10-06 14:46:46 UTC
dunno, it's storage code. Might help to see the actual request. That area wasn't touched for some time...so a problem may still exist.
Quite likely there is a problem on CFME side too supplying wrong/invalid parameters, so I guess we should look at both sides

Comment 12 Piotr Kliczewski 2016-10-06 14:51:21 UTC
Allon, please take a look whether it is known/fixed.

Comment 13 Michal Skrivanek 2016-10-07 08:11:49 UTC
also the exact content of the RHEV REST API call would really help, can you please get it?

Comment 16 Allon Mureinik 2016-11-24 10:18:02 UTC
(In reply to Piotr Kliczewski from comment #12)
> Allon, please take a look whether it is known/fixed.

According to the error you don't have enough space for the operation. What am I looking at? Why do we think that's a bug?

I'm obviously missing something basic here.

Comment 17 Allon Mureinik 2016-11-24 10:19:25 UTC
(In reply to Allon Mureinik from comment #16)
> (In reply to Piotr Kliczewski from comment #12)
> > Allon, please take a look whether it is known/fixed.
> 
> According to the error you don't have enough space for the operation. What
> am I looking at? Why do we think that's a bug?
> 
> I'm obviously missing something basic here.
If the issue is the error message itself - that's the regular format of any command failing its validate() call. The API returns the message, and it's up to the client to parse it

Comment 18 Piotr Kliczewski 2016-11-24 15:44:46 UTC
(In reply to Allon Mureinik from comment #16)
> 
> I'm obviously missing something basic here.

The bug is that we do not present error messages correctly. I just wanted to be sure that we do not have a bug in ovirt.

Thanks for clarification I just need to fix it on the UI

Comment 19 Piotr Kliczewski 2016-11-28 11:40:58 UTC
Luke,

In the request screen I see that the message is correct. There is no space in RHV storage domain so vm provisioning fails.

I am not sure what I could improve here. Please let me know about your suggestion or I will close it.

Comment 20 luke couzens 2016-11-28 13:02:00 UTC
Piotr,

If the messages are indeed correct then this can be closed.

Thanks for looking into it.

Comment 21 Piotr Kliczewski 2016-11-28 13:31:39 UTC
Luke,

Thanks closing