| Summary: | Review Request: obs-build - A generic package build script | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Neal Gompa <ngompa13> |
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | msuchy, package-review |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | msuchy:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-06 00:23:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Neal Gompa
2016-10-04 16:31:07 UTC
If you intend to package rest of OBS you may check chapter 5 from http://is.muni.cz/th/325243/fi_m/thesis.pdf Package looks good. My only concern is license. License check say it that everythin is just GPL and only GPL (v2) are: -------- obs-build-20160809/build-pkg obs-build-20160809/build-pkg-arch Can you check it? And probebly put comment in spec file to clarify which part use which license. I got the license tags from the SUSE spec[1] and translated it to our short tags. Since SUSE is the upstream and they have a spec, I trust that the tag information is correct. [1]: https://build.opensuse.org/package/view_file/openSUSE:Tools/build/build.spec?expand=1 (In reply to Miroslav Suchý from comment #1) > If you intend to package rest of OBS you may check chapter 5 from > http://is.muni.cz/th/325243/fi_m/thesis.pdf I do intend to try to package the rest of OBS, and I've seen Josef's thesis before. I've addressed the Net::RabbitMQ issue before OBS 2.7 was released[1], so that unblocks the OBS backend. I'm going to evaluate what the state of these things are for API and frontend, soon. [1]: https://github.com/openSUSE/open-build-service/commit/3cde6d39ae388e75a24779461651709a069262a0 > I do intend to try to package the rest of OBS, and I've seen Josef's thesis before. I've addressed the Net::RabbitMQ issue before OBS 2.7 was released[1], so that unblocks the OBS backend. I'm going to evaluate what the state of these things are for API and frontend, soon. Nice. Thank you for doing this. > I trust that the tag information is correct. I learned that OBS sometimes inherit long history, which was not 100% correct originally. Can you please check it? Here is complete output of licensecheck: *No copyright* GPL ------------------ obs-build-20160809/Build/LiveBuild.pm obs-build-20160809/build-recipe-livebuild obs-build-20160809/build-recipe-snapcraft GPL --- obs-build-20160809/Build.pm obs-build-20160809/Build/Arch.pm obs-build-20160809/Build/Archrepo.pm obs-build-20160809/Build/Collax.pm obs-build-20160809/Build/Deb.pm obs-build-20160809/Build/Debrepo.pm obs-build-20160809/Build/Kiwi.pm obs-build-20160809/Build/Mdkrepo.pm obs-build-20160809/Build/Repo.pm obs-build-20160809/Build/Rpm.pm obs-build-20160809/Build/Rpmmd.pm obs-build-20160809/Build/Snapcraft.pm obs-build-20160809/Build/Susetags.pm obs-build-20160809/Build/Zypp.pm obs-build-20160809/build obs-build-20160809/build-pkg-deb obs-build-20160809/build-pkg-rpm obs-build-20160809/build-recipe obs-build-20160809/build-recipe-arch obs-build-20160809/build-recipe-debbuild obs-build-20160809/build-recipe-debootstrap obs-build-20160809/build-recipe-dsc obs-build-20160809/build-recipe-kiwi obs-build-20160809/build-recipe-mock obs-build-20160809/build-recipe-preinstallimage obs-build-20160809/build-recipe-spec obs-build-20160809/build-vm obs-build-20160809/build-vm-docker obs-build-20160809/build-vm-ec2 obs-build-20160809/build-vm-emulator obs-build-20160809/build-vm-kvm obs-build-20160809/build-vm-lxc obs-build-20160809/build-vm-openstack obs-build-20160809/build-vm-qemu obs-build-20160809/build-vm-uml obs-build-20160809/build-vm-xen obs-build-20160809/build-vm-zvm obs-build-20160809/changelog2spec obs-build-20160809/common_functions obs-build-20160809/computeblocklists obs-build-20160809/createarchdeps obs-build-20160809/createdirdeps obs-build-20160809/createmdkdeps obs-build-20160809/createrepomddeps obs-build-20160809/createyastdeps obs-build-20160809/createzyppdeps obs-build-20160809/debtransform obs-build-20160809/debtransformbz2 obs-build-20160809/debtransformzip obs-build-20160809/download obs-build-20160809/emulator/emulator.sh obs-build-20160809/expanddeps obs-build-20160809/extractbuild obs-build-20160809/getbinaryid obs-build-20160809/init_buildsystem obs-build-20160809/initvm.c obs-build-20160809/killchroot obs-build-20160809/listinstalled obs-build-20160809/mkbaselibs obs-build-20160809/mkdrpms obs-build-20160809/order obs-build-20160809/queryconfig obs-build-20160809/signdummy obs-build-20160809/spec2changelog obs-build-20160809/spec_add_patch obs-build-20160809/spectool obs-build-20160809/substitutedeps obs-build-20160809/t/dist obs-build-20160809/t/live-build obs-build-20160809/unrpm obs-build-20160809/vc GPL (v2) -------- obs-build-20160809/build-pkg obs-build-20160809/build-pkg-arch GPL (with incorrect FSF address) -------------------------------- obs-build-20160809/test/common Unknown or generated -------------------- obs-build-20160809/Build/SimpleXML.pm obs-build-20160809/COPYING obs-build-20160809/Makefile obs-build-20160809/README obs-build-20160809/build-recipe-collax obs-build-20160809/build-recipe-simpleimage obs-build-20160809/build-vm-pvm obs-build-20160809/createdebdeps obs-build-20160809/debtransformxz obs-build-20160809/qemu-reg obs-build-20160809/runservices obs-build-20160809/telnet_login_wrapper obs-build-20160809/test-debtransform/run.sh obs-build-20160809/test/config obs-build-20160809/test/testbuild.sh I've revised the spec with an updated license tag, and included a patch to apply the clarifications to the package. Spec URL: http://kinginuyasha.enanocms.org/downloads/obs-build.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/obs-build-20160809-228.1.2.fc24.src.rpm APPROVED Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/obs-build obs-build-20161025-231.1.1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f2a93a2fb3 obs-build-20161025-231.1.1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d1a6aec546 obs-build-20161025-231.1.1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-56cfc3afd5 obs-build-20161025-231.1.1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. obs-build-20161025-231.1.1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. obs-build-20161025-231.1.1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. obs-build-20161025-231.1.1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |