| Summary: | [RFE] S30samba-start.sh should configure Windows' "Previous Versions" / shadow_copy2 by default | ||
|---|---|---|---|
| Product: | Red Hat Gluster Storage | Reporter: | John Call <jcall> |
| Component: | samba | Assignee: | Michael Adam <madam> |
| Status: | CLOSED WONTFIX | QA Contact: | storage-qa-internal <storage-qa-internal> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rhgs-3.2 | CC: | rhs-smb, ssaha |
| Target Milestone: | --- | Keywords: | FutureFeature |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-10-17 07:43:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
I would urge the 3.2 program team to consider this RFE for inclusion in RHGS 3.2. It's mostly a usability enhancement. We don't actually want to do this: Adding shadow-copy to the config adds an overhead to the share access. So it should only be done when snapshots are really used. We _could_ think about doing this not by default buy under certain special conditions to be defined. But then again, we do actually want to move away from the hook-script model of setting up samba shares. (It is hacked, in-flexible and buggy.) So currently it is a conscious decision that the admin should add the shadow-copy parts to the config if desired. |
The hook script to initialize Samba shares from Gluster volumes does not configure shadow_copy2 and other parameters required for Windows' Previous Version functionality to work. Additional manual configuration is required. This RFE would add the necessary configurations to the S30samba-start.sh so that this functionality just works / out-of-the-box. Would you please consider adjusting the hook script so that the share definition looks like this? [myVol] comment = Gluster myVol via libgfapi path = / guest ok = Yes read only = No vfs objects = shadow_copy2 glusterfs shadow:format = _GMT-%Y.%m.%d-%H.%M.%S shadow:snapprefix = * <-- can this be a wild card? shadow:sort = desc shadow:basedir = / shadow:snapdir = /.snaps glusterfs:loglevel = 7 glusterfs:logfile = /var/log/samba/glusterfs-myVol.%M.log glusterfs:volume = myVol