Bug 1381702

Summary: Remove the standard pulp unit storage path migration
Product: Red Hat Satellite Reporter: Mike McCune <mmccune>
Component: PulpAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: jcallaha
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bkearney, bmbouter, daviddavis, dkliban, ggainey, ipanova, jcallaha, jortel, mhrivnak, mmccune, pcreech, rchan, sthirugn, ttereshc, zhunting
Target Milestone: UnspecifiedKeywords: PrioBumpField
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pulp-2.8.7.3-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1385767 (view as bug list) Environment:
Last Closed: 2016-11-10 08:14:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1385767    
Attachments:
Description Flags
Suggested patch
none
verification screenshot
none
installer log
none
filesystem diff none

Description Mike McCune 2016-10-04 18:50:43 UTC
This migration is causing extreme customer pain in the duration it induces in the upgrade. While useful to have a singular storage location in /var/lib/pulp, the cost during the upgrade is too high and should be removed.

We are going to remove this step from the upgrade process and optionally add a utility script that can be run out-of-band if desired but not required for operation.

This should reduce the upgrade time significantly for upgrades from 6.1 to 6.2

Comment 2 Jeff Ortel 2016-10-14 20:32:58 UTC
The upstream issue: https://pulp.plan.io/issues/2323#note-23 references an attached .patch file and the pulp.spec used to test it.

Comment 3 Jeff Ortel 2016-10-17 14:46:33 UTC
Created attachment 1211411 [details]
Suggested patch

The patch tested with this recommended change to the 2.8.7 pulp.spec:

---

[jortel@localhost 2323]$ diff -ru ~/git/pulp/pulp.spec rpmbuild/SPECS/pulp.spec 
--- /home/jortel/git/pulp/pulp.spec	2016-10-14 15:27:39.228841171 -0500
+++ rpmbuild/SPECS/pulp.spec	2016-09-23 13:30:25.000000000 -0500
@@ -35,7 +35,7 @@
 
 Name: pulp
 Version: 2.8.7
-Release: 1%{?dist}
+Release: 2%{?dist}
 Summary: An application for managing software content
 Group: Development/Languages
 License: GPLv2
@@ -54,12 +54,17 @@
 %endif
 BuildRequires: rpm-python
 
+Patch0: storage-migration.patch
+
 %description
 Pulp provides replication, access, and accounting for software repositories.
 
 %prep
+
 %setup -q
 
+%patch0 -p1
+
 %build
 for directory in agent bindings client_consumer client_lib common devel
 do

Comment 5 Jeff Ortel 2016-10-19 14:15:08 UTC
jcalla,
The migration number is different for each plugin but the RPM migration (the most painful) is #28.  You should see "Standard storage path migration skipped." immediately following the skipped migration.

Comment 6 pulp-infra@redhat.com 2016-10-28 14:31:03 UTC
The Pulp upstream bug status is at CLOSED - WONTFIX. Updating the external tracker on this bug.

Comment 7 pulp-infra@redhat.com 2016-10-28 14:31:06 UTC
The Pulp upstream bug priority is at High. Updating the external tracker on this bug.

Comment 8 jcallaha 2016-11-05 20:07:52 UTC
Verified in Satellite 6.2.4 Snap 2

Upgrade time: 30m 16s

Saw three instances of notifications that "Standard storage path migration skipped." During the pulp migrations listed below:
pulp_docker.plugins.migrations
pulp_puppet.plugins.migrations
pulp_rpm.plugins.migrations

Attaching full install log, a screencap of two of the notifications, as well as a diff of the filesystem structure from directly before and after the upgrade.

Comment 9 jcallaha 2016-11-05 20:08:29 UTC
Created attachment 1217611 [details]
verification screenshot

Comment 10 jcallaha 2016-11-05 20:09:01 UTC
Created attachment 1217612 [details]
installer log

Comment 11 jcallaha 2016-11-05 20:09:38 UTC
Created attachment 1217613 [details]
filesystem diff

Comment 13 errata-xmlrpc 2016-11-10 08:14:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:2699