Bug 138171

Summary: lots of missing return statements in K&R code
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: tcp_wrappersAssignee: Thomas Woerner <twoerner>
Status: CLOSED CANTFIX QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 3CC: mattdm
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-10-30 22:17:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2004-11-05 09:50:47 UTC 
Description of problem:

I just tried to compile package tcp_wrappers-7.6-37 from 
Redhat Fedora Core 3 Test 3.

The compiler said

1.

fix_options.c(61): remark #117: non-void function "fix_options" should
return a
value
fix_options.c(104): remark #117: non-void function "fix_options"
should return a value
fix_options.c(128): remark #1011: missing return statement at end of
non-void function "fix_options"

Suggest upgrade this function only from K&R C to ISO C. K&R C has
been deprecated for about fifteen years now.

2.

fakelog.c(26): remark #1011: missing return statement at end of
non-void function "openlog"
fakelog.c(40): remark #1011: missing return statement at end of
non-void function "vsyslog"
fakelog.c(55): remark #1011: missing return statement at end of
non-void function "syslog"
fakelog.c(62): remark #1011: missing return statement at end of
non-void function "closelog"

More K&R code.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Matthew Miller 2006-07-10 22:29:59 UTC 
Fedora Core 3 is now maintained by the Fedora Legacy project for security
updates only. If this problem is a security issue, please reopen and
reassign to the Fedora Legacy product. If it is not a security issue and
hasn't been resolved in the current FC5 updates or in the FC6 test
release, reopen and change the version to match.

Thank you!
Comment 2 John Thacker 2006-10-30 22:17:02 UTC 
Closing per lack of response to previous request for information.
This bug was originally filed against a much earlier version of Fedora
Core, and significant changes have taken place since the last version
for which this bug is confirmed.

Note that FC3 and FC4 are supported by Fedora Legacy for security
fixes only.  Please install a still supported version and retest.  If
it still occurs on FC5 or FC6, please reopen and assign to the correct
version.  Otherwise, if this a security issue, please change the
product to Fedora Legacy.  Thanks, and we are sorry that we did not
get to this bug earlier.