Bug 1382017

Summary: Documentation issues on JSON file newnodes.json
Product: Red Hat OpenStack Reporter: Julio Villarreal <juvillar>
Component: documentationAssignee: Dan Macpherson <dmacpher>
Status: CLOSED CURRENTRELEASE QA Contact: RHOS Documentation Team <rhos-docs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.0 (Liberty)CC: dmacpher, juvillar, lbopf, mburns, srevivo
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-01 04:48:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Julio Villarreal 2016-10-05 14:13:02 UTC
Description of problem:
Documentation bug at https://access.redhat.com/documentation/en/red-hat-openstack-platform/8/paged/director-installation-and-usage/chapter-9-scaling-the-overcloud

at section 9.1. ADDING COMPUTE OR CEPH STORAGE NODES on the newnodes.json file. 

Version-Release number of selected component (if applicable):
RH OSP 8.0 director documentation.

How reproducible:
100%

Steps to Reproduce:
1. JSON file format is wrong. Import fails. 
2.
3.

Actual results:
File example is :


{
"nodes":[
    {
        "mac":[
            "dd:dd:dd:dd:dd:dd"
        ],
        "cpu":"4",
        "memory":"6144",
        "disk":"40",
        "arch":"x86_64",
        "pm_type":"pxe_ipmitool",
        "pm_user":"admin",
        "pm_password":"p@55w0rd!",
        "pm_addr":"192.0.2.207"
    },
    {
        "mac":[
            "ee:ee:ee:ee:ee:ee"
        ],
        "cpu":"4",
        "memory":"6144",
        "disk":"40",
        "arch":"x86_64",
        "pm_type":"pxe_ipmitool",
        "pm_user":"admin",
        "pm_password":"p@55w0rd!",
        "pm_addr":"192.0.2.208"
    },
]
}

Expected results:
File should not contain a comma at the end of the last json object : 

{
"nodes":[
    {
        "mac":[
            "dd:dd:dd:dd:dd:dd"
        ],
        "cpu":"4",
        "memory":"6144",
        "disk":"40",
        "arch":"x86_64",
        "pm_type":"pxe_ipmitool",
        "pm_user":"admin",
        "pm_password":"p@55w0rd!",
        "pm_addr":"192.0.2.207"
    },
    {
        "mac":[
            "ee:ee:ee:ee:ee:ee"
        ],
        "cpu":"4",
        "memory":"6144",
        "disk":"40",
        "arch":"x86_64",
        "pm_type":"pxe_ipmitool",
        "pm_user":"admin",
        "pm_password":"p@55w0rd!",
        "pm_addr":"192.0.2.208"
    }
]
}

Additional info:

Please remove the comma after the last node definition.

Comment 2 Dan Macpherson 2016-10-19 03:45:42 UTC
Hi Julio,

The comma should be removed and the JSON file should be correct now.

Was there anything else requires for this BZ?

Comment 3 Dan Macpherson 2016-12-01 04:48:32 UTC
No response in over a month. Closing this BZ.