Bug 1382024

Summary:	[RFE] Detect windows line endings (cause %post to silently fail)
Product:	Red Hat Enterprise Linux 7	Reporter:	Fabian Deutsch <fdeutsch>
Component:	pykickstart	Assignee:	David Cantrell <dcantrell>
Status:	CLOSED UPSTREAM	QA Contact:	Release Test Team <release-test-team>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.3	CC:	andanappa.mallikarjunappa.kori, jkonecny, jstodola, mkolman
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-15 18:46:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Fabian Deutsch 2016-10-05 14:32:24 UTC

Description of problem:
Currently windows line endings in a %post let can cause an %post-let to fail.
It will even fail silently if --erroronfail is not given.

This condition can be checked and can probably be avoided.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a ks with \r chars in a %post --erroronfail seciton
2. Start an automated install using this ks
3. anaconda will fail

Actual results:
anaconda will silently fail

Expected results:
anaconda will fail with an error - or correct the line endings

Additional info:

Comment 1 Martin Kolman 2017-01-18 14:04:47 UTC

I guess the scriptlets could be checked & fixed when the kickstart is being parsed. So maybe this is something for Pykickstart ? Adding Chris to CC.

Comment 2 Samantha N. Bueno 2017-05-26 16:11:03 UTC

We did not get to this in 7.4, so deferring to 7.5 planning.

Comment 3 Samantha N. Bueno 2017-09-01 11:25:18 UTC

We were unable to include this into our workload for 7.5, but we'd still like to look into this issue, so deferring it to 7.6 planning.

Comment 4 Jiri Konecny 2018-04-25 11:39:51 UTC

Based on the comment 1 the best component to fix this issue would be pykickstart. Changing component.

Comment 7 David Cantrell 2019-03-15 18:46:36 UTC

Filed upstream:
https://github.com/dcantrell/pykickstart/issues/260