Bug 138254

Summary: local variable used before set & printf problems
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: valgrindAssignee: Jakub Jelinek <jakub>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-11-09 09:58:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description David Binderman 2004-11-06 09:57:21 UTC
Description of problem:

I just tried to compile package valgrind-2.2.0-1 from 
Redhat Fedora Core 3 Test 3.

The compiler said


vg_proxylwp.c(538): remark #592: variable "req" is used before its
value is set

The source code is

            reply.req = req.request;

Suggest init req before first use.


vg_signals.c(1996): warning #268: the format string ends before this

The source code is

      VG_(printf)("got signal %d in LWP %d (%d)\n",
                  sigNo, VG_(gettid)(), VG_(gettid)(), VG_(main_pid));

Three %d, four trailing parameters. I'm not sure what the fix is for this.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
Actual results:

Expected results:

Additional info:

Comment 1 Jakub Jelinek 2004-11-09 09:58:04 UTC
The first warning is dubious, as icc doesn't take into account setjmp.
GCC's warning is much better in this case, fixed by making req volatile.