Bug 138256

Summary: missing expression in return stmt
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: xorg-x11Assignee: X/OpenGL Maintenance List <xgl-maint>
Status: CLOSED WONTFIX QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 3   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-11-10 21:56:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2004-11-06 10:00:53 UTC
Description of problem:

I just tried to compile package vnc-4.0-7 from 
Redhat Fedora Core 3 Test 3.

The compiler said

attributes.c:819: warning: `return' with no value, in function
returning non-void

The source code is

    if (*type != XrmQString)
        return;

but

static Bool
AppendEntry(
    XrmDatabase         *db,
    XrmBindingList      bindings,
    XrmQuarkList        quarks,
    XrmRepresentation   *type,
    XrmValuePtr         value,
    XPointer            data)

Suggest add expression to return statement. 



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Tim Waugh 2004-11-08 17:41:05 UTC
This code comes from xorg-x11, not vnc.

Comment 2 Kristian Høgsberg 2004-11-10 21:56:05 UTC
This code is part of Xprint which we don't ship.  Please file the bug
upstream in the http://bugs.freedesktop.org bugzilla. Thanks.  Oh, and
if you find more of these bugs, please provide more context, there's
over 5000 files in the Xorg distribution, findings attributes.c is
like finding a needle in a haystack.