Bug 1382655
| Summary: | Review Request: pology - CLI tools for PO files processing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-05 21:40:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Parag Nemade
2016-10-07 10:21:55 UTC
Why python2? Does it not work with python3?
make DESTDIR=$RPM_BUILD_ROOT install
→ %make_install
make VERBOSE=1 %{?_smp_mflags}
→ %make_build VERBOSE=1
%autosetup -n %{name}-%{version}
→ %autosetup
Licene tag says "GPLv3+", but you install two license files. On purpose?
Thanks for your review comment. Will post update soon in next 2 weeks. Updated to fix comment#1 issues Spec URL: http://pnemade.fedorapeople.org/pology.spec SRPM URL: http://pnemade.fedorapeople.org/pology-0.12-2.fc25.src.rpm /usr/share/doc/pology/api/ should be moved into python2-pology, or even possibly into pology-doc (as it describe the python API, iiuc). Fedora-review says: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2457600 bytes in 111 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation OTOH, pology-bash-completion should be merged into main pology rpm. There's no reason to have it separate, and it slows down the distribution and makes it's harder to use when there's too many packages. Rpmlint ------- Checking: pology-0.12-2.fc26.noarch.rpm python2-pology-0.12-2.fc26.noarch.rpm pology-bash-completion-0.12-2.fc26.noarch.rpm pology-0.12-2.fc26.src.rpm pology.noarch: W: no-manual-page-for-binary poascribe pology.noarch: W: no-manual-page-for-binary poepatch pology.noarch: W: no-manual-page-for-binary porewrap pology.noarch: W: no-manual-page-for-binary normalize-aspell-word-list pology.noarch: W: no-manual-page-for-binary pomtrans pology.noarch: W: no-manual-page-for-binary poselfmerge pology.noarch: W: no-manual-page-for-binary pohybdl pology.noarch: W: no-manual-page-for-binary traplint pology.noarch: W: no-manual-page-for-binary posieve pology.noarch: W: no-manual-page-for-binary posummit pology.noarch: W: no-manual-page-for-binary poediff python2-pology.noarch: W: no-documentation pology-bash-completion.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 13 warnings. That's OK, and the last two warnings should go away if packages are rearranged. Everything looks good, but I'm not setting the flag yet. Please rearrange the subpackages. Updated to fix comment#4 issues Spec URL: http://pnemade.fedorapeople.org/pology.spec SRPM URL: http://pnemade.fedorapeople.org/pology-0.12-3.fc25.src.rpm + package name is OK
+ license is acceptable (GPLv3+ and BSD)
+ license is specified correctly
+ builds and installs OK
+ python macros are used
+ %python_provide is used
+ fedora-review is happy
+ latest version (even if it's not very fresh ;))
Rpmlint
-------
Checking: pology-0.12-3.fc26.noarch.rpm
python2-pology-0.12-3.fc26.noarch.rpm
pology-doc-0.12-3.fc26.noarch.rpm
pology-0.12-3.fc26.src.rpm
pology.noarch: W: no-manual-page-for-binary poediff
pology.noarch: W: no-manual-page-for-binary porewrap
... etc ...
python2-pology.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 12 warnings.
Package is APPROVED.
Thank you for this package review. Yes the only recent released tarball is from 2014 ;-) Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pology pology-0.12-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f9cc099083 pology-0.12-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6e476bd5f7 pology-0.12-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6e476bd5f7 pology-0.12-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f9cc099083 pology-0.12-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. pology-0.12-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |