Bug 1383041

Summary: [infrastructure_public_178]When docker version<1.12 pod with sysctl should tip SysctlUnsupported
Product: OpenShift Container Platform Reporter: DeShuai Ma <dma>
Component: NodeAssignee: Andy Goldstein <agoldste>
Status: CLOSED CURRENTRELEASE QA Contact: DeShuai Ma <dma>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.3.1CC: agoldste, aos-bugs, dma, jokerman, mmccomas, wmeng
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-11 13:07:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description DeShuai Ma 2016-10-09 09:38:29 UTC
Description of problem:
Now in upstream when docker version < 1.12, when create pod with sysctl, it will tip "SysctlUnsupported Docker before 1.12 does not support sysctls". But in openshift the pod can running well.

Version-Release number of selected component (if applicable):
openshift v3.3.1.1
docker: 1.10.3

How reproducible:
Always

Steps to Reproduce:
1.Create a pod with sysctl
$ oc create -f https://raw.githubusercontent.com/mdshuai/testfile-openshift/master/sysctls/sysctl-safe.yaml

2.Check the pod status
$ oc get pod

Actual results:
2. Pod is running.
[root@ip-172-18-10-30 ~]# oc get pod hello-pod
NAME        READY     STATUS    RESTARTS   AGE
hello-pod   1/1       Running   0          1m

Expected results:
2. Pod status is SysctlUnsupported when docker version < 1.12

Additional info:
2. result on kube env with docker 1.10.3
[root@ip-172-18-6-200 ~]# kubectl create -f https://raw.githubusercontent.com/mdshuai/testfile-openshift/master/sysctls/sysctl-safe.yaml
pod "hello-pod" created
[root@ip-172-18-6-200 ~]# kubectl get pod
NAME        READY     STATUS              RESTARTS   AGE
hello-pod   0/1       SysctlUnsupported   0          4s
[root@ip-172-18-6-200 ~]# kubectl describe pod hello-pod|grep SysctlUnsupported
Reason:		SysctlUnsupported
  2m		2m		1	{kubelet 127.0.0.1}			Warning		SysctlUnsupported	Docker before 1.12 does not support sysctls

Comment 1 Dan McPherson 2016-10-10 11:23:47 UTC
I'm not sure this makes sense.  Red Hat's docker 1.10 should support sysctls.  Otherwise there isn't much point in putting this change into 3.3.x.

Comment 2 Andy Goldstein 2016-10-10 14:49:00 UTC
This is not a bug. As Dan mentioned, we backported sysctls to docker 1.10. We accordingly modified OpenShift to support sysctls in 3.3.x against our docker 1.10.

Comment 3 DeShuai Ma 2016-10-11 02:20:52 UTC
Thanks, verify this bug. for docker1.10 sysctls works.
openshift v3.3.1.1