Bug 1383438

Summary: ceph-ansible v1.0.8 lacks "ceph_stable_rh_storage"
Product: Red Hat Storage Console Reporter: Ken Dreyer (Red Hat) <kdreyer>
Component: ceph-ansibleAssignee: Sébastien Han <shan>
Status: CLOSED CURRENTRELEASE QA Contact: ceph-qe-bugs <ceph-qe-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2CC: adeza, aschoen, ceph-eng-bugs, gmeno, nthomas, sankarshan, seb
Target Milestone: ---   
Target Release: 3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-11 23:05:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Ken Dreyer (Red Hat) 2016-10-10 15:26:08 UTC
Description of problem:
ceph-ansible v1.0.5 had "ceph_stable_rh_storage" variables. Our docs tell users to use these variables, and our ceph-installer application also uses ceph_stable_rh_storage.

ceph_stable_rh_storage
ceph_stable_rh_storage_repository_path
ceph_stable_rh_storage_mount_path
ceph_stable_rh_storage_iso_path
ceph_stable_rh_storage_version

ceph-ansible v1.0.8 renames these variables to "ceph_rhcs", which breaks backwards compatibility.

This will cause confusion for users who are reading older versions of the docs, and older versions of ceph-installer.

Version-Release number of selected component (if applicable):
ceph-ansible-1.0.8-1.el7scon


How reproducible:
always

Steps to Reproduce:
1. Install ceph-ansible 1.0.8
2. Set "ceph_stable_rh_storage: true"

Actual results:
ceph_stable_rh_storage has no effect

Expected results:
ceph_stable_rh_storage should work as documented with ceph-ansible v1.0.8, or else we rewrite the docs and ship a new ceph-installer version at the same time?

Comment 2 seb 2016-10-13 09:09:25 UTC
Even if it's disruptive, it's probably easier to rewrite the doc and ship a new version for ceph-installer.
I can potentially implement a backward compatibility in 1.0.8 so let me know which solution you prefer.

Comment 3 Ken Dreyer (Red Hat) 2016-10-13 14:14:20 UTC
Personally I think we should preserve backwards compatibility, at least for the "ceph-ansible v1" release series.

Comment 4 seb 2016-10-13 16:25:36 UTC
can we have someone testing this branch?
for both CDN and ISO install?

https://github.com/ceph/ceph-ansible/pull/1032

Thanks!

Comment 5 Ken Dreyer (Red Hat) 2017-01-11 23:05:55 UTC
We never shipped v1.0.8, and v2.1.1 has the backwards-compatible variables, so I think we're good here.