Bug 1383466

Summary:	Update download_template to use RestClient instead of open-uri for Azure
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Providers	Assignee:	Daniel Berger <dberger>
Status:	CLOSED ERRATA	QA Contact:	Jeff Teehan <jteehan>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	5.7.0	CC:	cpelland, gblomqui, jfrey, jhardy, jteehan, obarenbo
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.6.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	provider:azure
Fixed In Version:	5.6.3.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-30 19:56:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	Azure	Target Upstream Version:
Embargoed:

Description Satoe Imaishi 2016-10-10 17:42:26 UTC

From PR: https://github.com/ManageIQ/manageiq/pull/10858

Beyond the fact that the open-uri.rb code requires too much branching, there's no easy way to set ssl options that I can see. Furthermore, we already use RestClient internally.

This is easier to use, easier to read, and is more flexible to boot.

Comment 2 CFME Bot 2016-10-11 13:11:03 UTC

New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/0dd6f5ddab043da364165802f5d7700eb16a083f

commit 0dd6f5ddab043da364165802f5d7700eb16a083f
Author:     Greg Blomquist <blomquisg>
AuthorDate: Tue Sep 13 15:24:26 2016 -0400
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Tue Oct 11 09:07:42 2016 -0400

    Merge pull request #10858 from djberg96/azure_refresh_parser
    
    Update download_template to use RestClient instead of open-uri for Azure
    (cherry picked from commit 60dae81c8f0a1bb336df955f0d8fa0d0fd5b1ae6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1383466

 .../azure/cloud_manager/refresh_parser.rb          | 22 ++++++++--------------
 .../azure/cloud_manager/refresher_spec.rb          |  2 ++
 2 files changed, 10 insertions(+), 14 deletions(-)

Comment 3 Jeff Teehan 2016-11-09 00:17:58 UTC

I'll take this.

Comment 4 Jeff Teehan 2016-11-09 00:29:05 UTC

New code optimization is working fine, and looks a lot cleaner.  I'd be happier if we formatted the header as well, but it shouldn't matter until ms changes something.  Moving to verified tested on 563 using 10.16.6.220

Comment 6 errata-xmlrpc 2016-11-30 19:56:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2839.html