Bug 1383545

Summary: Do not override values which are specified explicitly in heat template NeutronL3HA
Product: Red Hat OpenStack Reporter: Shinobu KINJO <skinjo>
Component: python-tripleoclientAssignee: RHOS Maint <rhos-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Arik Chernetsky <achernet>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.0 (Liberty)CC: amuller, aschultz, beagles, hbrock, jcoufal, jslagle, mburns, rhel-osp-director-maint
Target Milestone: ---   
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-11 15:36:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Shinobu KINJO 2016-10-11 00:53:17 UTC
Description of problem:

When you change value 'True' to 'False' in NeutronL3HA in overcloud.yaml, it ends up with becoming 'True' because tripleoclient overrides this value on its own decision.

If this behaviour is true without no exception, we should not allow users to change value of NeutronL3HA.
Using parameter_defaults sounds reasonable but it's more better for tripleocliet to not do anything by its own decision.


// * Setting
NeutronL3HA:
    default: 'False'
    description: Whether to enable l3-agent HA

// * Result
# Enable high availability for virtual routers.
# l3_ha = False
l3_ha = True


[1]https://github.com/openstack/tripleo-heat-templates/blob/2.1.0/puppet/compute.yaml#L201-L204
[2]https://github.com/openstack/python-tripleoclient/blob/06325dea70f43acc37b9a7d93380ef88f02efce7/tripleoclient/v1/overcloud_deploy.py#L178-L194

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Jaromir Coufal 2017-08-10 19:35:32 UTC
Seems like specific Neutron issue, moving to Networking DFG (might also be CLI/Workflows). If this appears to be broader issue, please create broader bug with more info.

Comment 3 Brent Eagles 2017-09-11 15:36:54 UTC
As of OSP10(Newton), NeutronL3HA is not controlled the tripleo client and be explicitly enabled or disabled by setting NeutronL3HA to true or false respectively.