Bug 1383637

Summary:	Middleware - New JDBC Driver wrong params - No failure message
Product:	Red Hat CloudForms Management Engine	Reporter:	Hayk Hovsepyan <hhovsepy>
Component:	Providers	Assignee:	Mike Thompson <mithomps>
Status:	CLOSED EOL	QA Contact:	Hayk Hovsepyan <hhovsepy>
Severity:	medium	Docs Contact:
Priority:	high
Version:	unspecified	CC:	cpelland, dajohnso, hrupp, jfrey, jhardy, mfoley, mithomps, mmahoney, obarenbo, simaishi, vprusa
Target Milestone:	GA	Keywords:	TestOnly, Triaged, ZStream
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	Hawkular
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1440575 (view as bug list)		Environment:
Last Closed:	2017-10-12 07:25:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	Middleware	Target Upstream Version:
Bug Depends On:	1383426
Bug Blocks:	1440575

Description Hayk Hovsepyan 2016-10-11 10:11:44 UTC

Description of problem:
Adding new JDBC driver with wrong params does not fail in UI.

Version-Release number of selected component (if applicable):
5.7.0.4-alpha1.20161005153002_cfc8a23

How reproducible:
always

Steps to Reproduce:
1. From UI of Server, select "Add JDBC Driver" menu item.
2. Select some jar file to upload (could be anything)
3. The rest of input params fill some wrong values.
4. Submit.

Actual results:
In UI it shows success message "JDBC Driver has been installed on this server".
But in EAP server.log of course it fails.

Expected results:
The failure notification should be shown in UI after submitting the form with wrong input values.

Comment 2 Heiko W. Rupp 2016-10-11 10:18:28 UTC

Just a note - we have *no* way of knowing that a jar is valid on the MiQ UI, so whatever we will come up with, will be an asynchronous notification of success or failure, while the message after submitting can only mean "yes I have submitted that".

Perhaps for this specific BZ, we should just change the toast to something like "JDBC Driver was submitted for installation"

Comment 3 Hayk Hovsepyan 2016-10-11 12:53:08 UTC

If there will be way to chose JDBC Driver from list, while creating Datasource, then user will see whether driver installation was successful or not.

Comment 4 Mike Thompson 2016-11-04 15:38:05 UTC

(In reply to Hayk Hovsepyan from comment #3)
> If there will be way to chose JDBC Driver from list, while creating
> Datasource, then user will see whether driver installation was successful or
> not.

BTW there will be a list to choose JDBC Drivers from (I should be done with that today). https://bugzilla.redhat.com/show_bug.cgi?id=1383426

Comment 5 Vojta Prusa 2016-12-07 15:08:59 UTC

*** Bug 1398398 has been marked as a duplicate of this bug. ***

Comment 6 Mike Thompson 2017-04-02 10:01:17 UTC

Added smart JDBC Driver defaults since there really is not much more validation that we can do (required fields is about all that can be done).

See: https://github.com/ManageIQ/manageiq-ui-classic/pull/876

Comment 9 Hayk Hovsepyan 2017-10-10 11:57:13 UTC

Tested on 5.9.0.1.20171004215954_13427ce 

several things failed to verify:

1. Notification message is "JDBC Driver "XYZ" has been installed on this server.", but should be "JDBC Driver "XYZ" has been submitted to installation on this server."

2. IBM DB2 default driver class should be "com.ibm.db2.jcc.DB2Driver".

3. Sybase default driver class should be "com.sybase.jdbc4.jdbc.SybDriver".

Comment 10 Mike Thompson 2017-10-12 00:15:46 UTC

@hayk This is very confusing to me because the BZ is so old. This should definitely be a new BZ as the original BZ is a year old. Please close and create new BZ if you agree.

Comment 11 Hayk Hovsepyan 2017-10-12 07:25:13 UTC

Agreed, created new one https://bugzilla.redhat.com/show_bug.cgi?id=1501155