| Summary: | Review Request: python-restructuredtext-lint - reStructuredText linter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julien Enselme <jujens> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-10 03:29:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Julien Enselme
2016-10-11 15:12:53 UTC
Name should be "python-restructuredtext-lint" (dashes are nowadays preferred: https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Separators). %description should be extended a bit: e.g. what types of errors does this detect? Is a separate executable needed for python2 and 3? rst is not python-version-specific, so most likely there should be just one executable. > Name should be "python-restructuredtext-lint" Fixed. > %description should be extended a bit: Done. > Is a separate executable needed for python2 and 3? I don't think so indeed. Corrected. Spec URL: http://dl.jujens.eu/SPECS/python-restructuredtext-lint.spec SRPM URL: http://dl.jujens.eu/SRPMS/python-restructuredtext-lint-0.17.2-2.fc24.src.rpm It reports errors and warning including:\
- Unknow directives\
- Wrong usage of directives\
- Inconsitencies in title levels\
- unexpected unindent
unknown, wrong, inconsistencies (case and typos)
"| xargs rm -f" → -delete
+ license is acceptable ("unlicense")
+ license is specified correctly
+ package name is OK
+ standard python packaging template is used
+ %python_provide is present
+ builds and installs OK
+ provides/requires look OK
Package is APPROVED.
> unknown, wrong, inconsistencies (case and typos) Corrected > "| xargs rm -f" → -delete It's better. SPEC updated. Thanks for the review. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-restructuredtext-lint python-restructuredtext-lint-0.17.2-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e14325f41d python-restructuredtext-lint-0.17.2-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-975059890f python-restructuredtext-lint-0.17.2-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e14325f41d python-restructuredtext-lint-0.17.2-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-975059890f python-restructuredtext-lint-0.17.2-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. python-restructuredtext-lint-0.17.2-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |