Bug 1383799

This bug suggests a certain approach to a problem  you want to solve. Could you describe the "problem" or let's say use case in more details. Maybe there is a better solution.

E.g. I can imagine that branding change would sometimes require additional image and/or change of CSS.

Other question here is how rpm dependencies should behave. If a possibility to replace stock rpm with custom is required then the stock needs to be, e.g., a weak dependency otherwise uninstallation of it might cause uninstallation of whole IPA.

Hi Petr,

The specific problem I'm looking at is in the maintenance of RHEL rebuilds.  A number of debranding passes inevitably misses items.  Today the various rebuilds each maintain their own patch set to remove the RHEL IDM branding.  I'm hopeful there is a way to get the branding shifted somewhere so that the process is cleaner and less likely to error out.

Each time an errata is released today the package needs to be customized and there is potential that the various diff's do not apply correctly - generating maintenance cost.

My initial thoughts on having the branding in a separate package allow the rebuild community to simply not publish the one branding package and instead provide a different one that has similar RPM provides.

If the branding files are truly separate from the application files, a number of options open up to the rebuild community.  That being said; it makes sense that FreeIPA provide the FreeIPA artwork.

Taking this from different angle... Petr, would it be maybe more achievable to change the branding via FreeIPA Web UI plugin that the customer would deploy? If the plugin is able to change paths to different design elements, the customer would not have to change RPMs.

Web UI plugin is able to do that. But some parts might not be straightforward - requires modification of render/create methods or changing the html after render/creation.

Changing files is usually easier but more limiting.

Plugin itself can be delivered as an additional rpm.

Plugin examples:
- https://pvoborni.fedorapeople.org/plugins/
- https://pvoborni.fedorapeople.org/plugins/demo/demo.js

Plugin docs:
- https://pvoborni.fedorapeople.org/doc/#!/guide/Plugins

That seems viable to me.  My javascript is terribly rusty, but if the hooks are in place for the page render that should be pretty elegant overall.

Right. I think that any solution that would let you avoid rebuilding RPMs with every update is better than what you have currently :-)

BTW, you can see a public FreeIPA demo, to see Petr's example plugin in action:
https://ipa.demo1.freeipa.org/ipa/ui/

I'll see about whipping up a plugin that changes out:
 - header-logo.png
 - login-screen-logo.png
 - product-name.png
 - favicon.ico

Any pointers would be helpful. Looking over the sample plugins there I've realized my javascript experience pre-dates jquery.  Yark!

If it is just about files then it might be possible to replace them via url rewrites, basically create:

# cat /etc/httpd/conf.d/ipa-z-brand.conf 
RewriteEngine on

RewriteRule ^/ipa/ui/images/(.*)    /ipa/ui/custombrand/images/$1 [PT,NC]
RewriteRule ^/ipa/ui/favicon.ico    /ipa/ui/custombrand/favicon.ico [PT,NC]

Unfortunately this alone doesn't work because the rewrite rule is not loaded in virtual host for port 443 so following line is required to be added to /etc/httpd/conf.d/nss.conf in the VirtualHost element:
  Include /etc/httpd/conf.d/ipa-*-brand.conf

A possible fix would be IPA to include this rewrite rule and then anybody can put files to location(s) based on the rewrite(s).

Upstream ticket:
https://fedorahosted.org/freeipa/ticket/6421

This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

This bug appears to have been reported against 'rawhide' during the Fedora 29 development cycle.
Changing version to '29'.

This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

This message is a reminder that Fedora 32 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '32'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 32 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Fedora 32 changed to end-of-life (EOL) status on 2021-05-25. Fedora 32 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.