Bug 1383918

Summary:	NSPR 4.13 broke ntlm_auth helper, upgrade to 4.13.1 necessary
Product:	[Fedora] Fedora	Reporter:	Joonas Lahtinen <joonas.lahtinen>
Component:	nspr	Assignee:	Daiki Ueno <dueno>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	24	CC:	dueno, dwmw2, emaldona, gecko-bugs-nobody, jhorak, kengert, pjasicek, ryan.r.ware
Target Milestone:	---	Keywords:	Regression
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	nspr-4.13.1-1.fc24	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-12-07 14:48:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Joonas Lahtinen 2016-10-12 07:28:13 UTC

Description of problem:


Version-Release number of selected component (if applicable): 49


How reproducible: Always


Steps to Reproduce:

  1. Try to visit a site which uses NTLM authentication

Actual results:

  Password is prompted.

Expected results:

  SSO should work through ntlm_auth.

Additional info:

ntlm_auth trace;

ntlmfoo.44135:write(2, "Got 'YR' from squid (length: 2)."..., 33) = 33
ntlmfoo.44135:write(1, "YR TlRMTVNTUAABAAAABYIIYgAAAAAoA"..., 60) = -1 EPIPE (Broken pipe)

firefox trace;

write(78, "YR\n", 3)                    = 3
read(80, 0x7ffdaef55598, 1024)          = -1 EAGAIN (Resource temporarily unavailable)
close(80)                               = 0
close(78)                               = 0

Comment 1 David Woodhouse 2016-10-12 07:37:45 UTC

This was working in 48.0.1. Broken in 49.0

Comment 2 David Woodhouse 2016-10-12 08:51:19 UTC

Not Firefox; it was broken because NSPR randomly changed its semantics and now pipes are non-blocking. And now Firefox gets a completely unexpected -EAGAIN when it reads from a pipe which always *used* to be blocking.

Comment 3 David Woodhouse 2016-10-12 09:07:32 UTC

Scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=16058155 fixes this

Comment 4 Kai Engert (:kaie) (inactive account) 2016-10-13 14:05:48 UTC

(In reply to David Woodhouse from comment #3)
> Scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=16058155
> fixes this

how?

Comment 5 David Woodhouse 2016-10-13 14:35:56 UTC

Just by reverting the offending patch.

Comment 6 Kai Engert (:kaie) (inactive account) 2016-10-20 14:37:59 UTC

Thanks David.

We've just released an upstream NSPR 4.13.1 release, where the only change is the reversal of this function.

Daiki, could you please work on NSPR package updates, to fix this bug?
Thanks in advance.

Comment 7 Fedora Update System 2016-10-22 02:24:33 UTC

nspr-4.13.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-86a2119f42

Comment 8 Fedora Update System 2016-10-22 03:53:51 UTC

nspr-4.13.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7dce812c00

Comment 9 Fedora Update System 2016-10-22 11:53:48 UTC

nspr-4.13.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f0d43a359d

Comment 10 Fedora Update System 2016-10-23 22:52:44 UTC

nspr-4.13.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2016-10-25 20:21:22 UTC

nspr-4.13.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Daiki Ueno 2016-12-07 14:48:39 UTC

Closing as the fixed package is already in Fedora 24 stable.