Bug 1383923

retargetting as blocking the docs bug since this is a docs only fix (removing it from blocking https://bugzilla.redhat.com/show_bug.cgi?id=1337794

adding a note here for docs folks the 'enable_telemetry' should be placed into the undercloud.conf under the [DEFAULT] section. 

I sanity checked today that adding it to the very *end* of the file (and so under 'auth') doesn't have the desired effect since after the undercloud upgrade my telemetry services are not running:

        [stack@instack ~]$ tail undercloud.conf 
        # Sensu service password. If left unset, one will be automatically
        # generated. (string value)
        #undercloud_sensu_password = <None>

        # HAProxy stats password. If left unset, one will be automatically
        # generated. (string value)
        #undercloud_haproxy_stats_password = <None>
        #

        enable_telemetry = true
        [stack@instack ~]$ openstack-service status | grep "aodh\|ceilo"
        Failed to get properties: Unit name openstack-zaqar@.service is missing the instance name.
        MainPID=0 Id=openstack-aodh-evaluator.service ActiveState=inactive
        MainPID=0 Id=openstack-aodh-listener.service ActiveState=inactive
        MainPID=0 Id=openstack-aodh-notifier.service ActiveState=inactive
        MainPID=0 Id=openstack-ceilometer-api.service ActiveState=inactive
        MainPID=0 Id=openstack-ceilometer-central.service ActiveState=inactive
        MainPID=0 Id=openstack-ceilometer-collector.service ActiveState=inactive
        MainPID=0 Id=openstack-ceilometer-notification.service ActiveState=inactive
        [stack@instack ~]$

FYI this has changed since we merged: https://review.openstack.org/#/c/386702/

I would document this more along the lines of: https://review.openstack.org/#/c/396690/

Hi guys,

I've included the following note in the upgrade doc:

"Red Hat OpenStack Platform director 10 disables OpenStack Telemetry (ceilometer) as default. If using OpenStack Telemetry on the Undercloud, set the enable_telemetry parameter in the [DEFAULT] section of the undercloud.conf file in your stack user’s home directory. Without this parameter, the Undercloud upgrade disables OpenStack Telemetry."

However, should I remove the last line as per the recommendation in comment #3?

Hi Dan, you can remove the first line too, looking at https://review.openstack.org/#/c/386702/ and https://review.openstack.org/#/c/396690/ it seems this has been completely flipped. That is, in OpenStack Platform director 10 OpenStack Telemetry  services (ceilometer/aodh) on the undercloud are enabled by default. The operator can explicitly disable them by setting 'enable_telemetry=False' in the undercloud.conf configuration file, prior to running the "openstack undercloud upgrade" command to upgrade the undercloud.  

I'm running this on one of my envs right now to confirm (haven't even looked at this since verifying in comment #2 to be honest...), but looking at rhos-10-patches branch of instack-undercloud, it does appear the right bits have landed into OSP10 @ 
https://code.engineering.redhat.com/gerrit/gitweb?p=instack-undercloud.git;a=blob;f=elements/puppet-stack-config/puppet-stack-config.pp;h=387e61886ef3ed54cf8de22a9d89a9e2fbcc3f0a;hb=refs/heads/rhos-10.0-patches#l165 (enable_telemetry defaults to true, even if it isn't set in the undercloud.conf) from https://review.openstack.org/#/c/386702/

(In reply to marios from comment #6)

...

> I'm running this on one of my envs right now to confirm (haven't even looked
> at this since verifying in comment #2 to be honest...), but looking at

...

confirmed without having to do anything, after the undercloud is upgraded to OSP10 I have: 


[stack@instack ~]$ openstack-service status | grep -ni "ceilo\|aodh"
Failed to get properties: Unit name openstack-zaqar@.service is missing the instance name.
4:MainPID=7887 Id=openstack-aodh-evaluator.service ActiveState=active
5:MainPID=5864 Id=openstack-aodh-listener.service ActiveState=active
6:MainPID=5879 Id=openstack-aodh-notifier.service ActiveState=active
7:MainPID=6937 Id=openstack-ceilometer-central.service ActiveState=active
8:MainPID=6844 Id=openstack-ceilometer-collector.service ActiveState=active
9:MainPID=6831 Id=openstack-ceilometer-notification.service ActiveState=active

It looks like this won't affect the OSP 9 to 10 upgrade, only just the upstream Newton minor release updates.

I've reverted the content. And if there's no objections, I'll close this BZ.

Closing as WONTFIX since the behavior has been reverted and does not require a docs note. If changes are required, please feel free to reopen this BZ.