Bug 1383958

Summary: rlGetPrimaryArch throws error
Product: [Fedora] Fedora Reporter: Martin Korbel <mkorbel>
Component: beakerlibAssignee: Dalibor Pospíšil <dapospis>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 24CC: azelinka, dapospis, jprokes, mkyral, muller
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: beakerlib-1.13 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-26 07:57:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
rlGet*Arch.patch none

Description Martin Korbel 2016-10-12 09:09:02 UTC
Description of problem:
The beakerlib method rlGetPrimaryArch throws error on Fedora systems.


Version-Release number of selected component (if applicable):
beakerlib-1.11-1

How reproducible:
100%

Steps to Reproduce:
1. Execute these commands
> . /usr/share/beakerlib/beakerlib.sh
> rlGetPrimaryArch

Actual results:
:: [ 08:23:58 ] :: [ ERROR   ] :: rlGetPrimaryArch: Concept of primary and secondary architectures is defined on RHEL only
> BEAKERLIB_JOURNAL not defined in the environment
> x86_64

Expected results:
The same output as on the RHEL systems

> x86_64

Additional info:

Comment 1 Dalibor Pospíšil 2016-10-13 08:02:06 UTC
As I've already mentioned in email communication at https://lists.fedorahosted.org/archives/list/beaker-devel@lists.fedorahosted.org/thread/T3KYBSBZGV6VFW4RHENVSLQL6R7X3GS2/#6AH2LGZ2YHEQ664MRVOFQ3HP2HQBJG6B I would like to change rlGetPrimaryArch not to print error but only warning or just info and rlGetSecondaryArch to print error witch reasonable exit code.

Also I'm thinking of undeprecating rlGetArch. We should discuss the future of these functions in bigger group of devels.

Comment 2 Dalibor Pospíšil 2016-10-14 10:23:27 UTC
Created attachment 1210471 [details]
rlGet*Arch.patch

Proposed change of the functions. Please take a look.

Comment 3 Martin Kyral 2017-04-05 06:14:37 UTC
The patch looks fine. Thanks.

Comment 4 Fedora End Of Life 2017-07-25 23:26:32 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.