Bug 1384242

Summary: Review Request: python-astropy-helpers - Utilities for building and installing Astropy and affiliated package
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: Package ReviewAssignee: Zbigniew Jędrzejewski-Szmek <zbyszek>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dkrejci, package-review, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-12 18:51:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1331062, 1356123    
Bug Blocks:    

Description Orion Poplawski 2016-10-12 22:35:58 UTC 
Spec URL: https://www.cora.nwra.com/~orion/fedora/python-astropy-helpers.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python-astropy-helpers-1.2-1.fc26.src.rpm
Description:
This project provides a Python package, astropy_helpers, which includes many
build, installation, and documentation-related tools used by the Astropy
project, but packaged separately for use by other projects that wish to
leverage this work.

Fedora Account System Username: orion

scratch build - http://koji.fedoraproject.org/koji/taskinfo?taskID=16067724
Comment 1 Dominika Krejčí 2016-10-14 08:47:21 UTC 
Hi Orion, links to SPEC and SRPM are invalid.
Comment 2 Orion Poplawski 2016-10-14 13:10:48 UTC 
Sorry, should be working now.
Comment 3 Dominika Krejčí 2016-10-21 11:25:17 UTC 
Is there any special reason why do you use `%{pythonX_pkgversion}` macro? I think you could use just 3 or 2, e.g. `python3-devel`.

Could you also specify Python 2 Requires?
python-devel -> python2-devel
python-setuptools -> python2-setuptools
pytest -> python2-pytest
numpy -> python2-numpy
python-shipnx -> python2-sphinx

Could you be please more specific in the `%files` section and do not use just `%{pythonX_sitelib}/*`, but for example this? %{python3_sitelib}/*astropy_helpers*.egg-info/
%{python3_sitelib}/astropy_helpers/
Comment 4 Orion Poplawski 2016-10-21 20:05:18 UTC 
(In reply to Dominika Krejčí from comment #3)
> Is there any special reason why do you use `%{pythonX_pkgversion}` macro? I
> think you could use just 3 or 2, e.g. `python3-devel`.

For EPEL support - see https://fedoraproject.org/wiki/PackagingDrafts:Python3EPEL

> Could you also specify Python 2 Requires?
> python-devel -> python2-devel
> python-setuptools -> python2-setuptools
> pytest -> python2-pytest
> numpy -> python2-numpy
> python-shipnx -> python2-sphinx

Same reason - EPEL uses the old names.

> Could you be please more specific in the `%files` section and do not use
> just `%{pythonX_sitelib}/*`, but for example this?
> %{python3_sitelib}/*astropy_helpers*.egg-info/
> %{python3_sitelib}/astropy_helpers/

How about:

%{python3_sitelib}/astropy_helpers*

Spec URL: https://www.cora.nwra.com/~orion/fedora/python-astropy-helpers.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/python-astropy-helpers-1.2-2.el7.src.rpm

* Fri Oct 21 2016 Orion Poplawski <orion.com> - 1.2-2
- Be more explicit in %%files
Comment 5 Zbigniew Jędrzejewski-Szmek 2016-11-12 18:51:25 UTC 
Oops, package already exists: https://admin.fedoraproject.org/pkgdb/package/rpms/python-astropy-helpers/.