Bug 1384286

Summary:	HE setup fails with misleading messages when LUN contains partitions.
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Germano Veit Michel <gveitmic>
Component:	ovirt-hosted-engine-setup	Assignee:	Simone Tiraboschi <stirabos>
Status:	CLOSED WONTFIX	QA Contact:	meital avital <mavital>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.0.3	CC:	gklein, lsurette, ykaul, ylavi
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-22 13:36:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Germano Veit Michel 2016-10-13 02:13:05 UTC

Description of problem:

Deploying HE over block storage that already contains some data (partitions to be specific) fails due to BZ 1215427 (NOTABUG).

Once BZ 1343043 is released, we will have notes regarding it.

However, during Hosted Engine deployment, it specifically asks to use "Force", so the user assumes that will not be a problem (but it will be).

[ INFO  ] Connecting to the storage server
          The following luns have been found on the requested target:
          	[1]	36001405227484ee340640e38e286ca39	70GiB	LIO-ORG	hostedengine2
          		status: used, paths: 1 active
         
          Please select the destination LUN (1) [1]: 
          The selected device is already used.
          To create a vg on this device, you must use Force.
          WARNING: This will destroy existing data on the device.
          (Force, Abort)[Abort]? Force

Then, after answering all those questions and confirming everything, it fails with:

[ ERROR ] Error creating Volume Group: Failed to initialize physical device: ("[u'/dev/mapper/36001405227484ee340640e38e286ca39']",)
[ ERROR ] Failed to execute stage 'Misc configuration': Failed to initialize physical device: ("[u'/dev/mapper/36001405227484ee340640e38e286ca39']",)

There are two problems:
1) The error is not clear and also incorrect. Is says error creating the VG. But it's the PV that failed to create. This can lead to the user to wrong investigation paths.
2) There is no indication that the "Force" above did not work (it did not). This leaves the user wondering what went wrong. So I assume the user starts investigating what could be wrong, retrying the setup each time. And every time if fails, all those questions may need to be answered again (unless using answers file). It can be quite frustrating.

Version-Release number of selected component (if applicable):
rhvh-4.0-0.20160919
ovirt-hosted-engine-setup-2.0.2.2-2.el7ev.noarch
vdsm-4.18.13-1.el7ev.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create new LUN
2. Create partitions in the new LUN
3. Try to deploy HE in this LUN.

Actual results:
Fails with no clear indication on what is wrong

Expected results:
More user friendly: fails with clear indications, possibly pointing to documentation.

AND/OR

Offers to dd zero over the LUN*

*just in this special case for HE setup, not general storage domain creation after RHV is deployed.

Comment 1 Germano Veit Michel 2016-10-13 02:18:59 UTC

Can't we detect that there are partitions when the LUN is selected (and detected to not be clean)? And then fail right there (and/or) suggest the 'dd' or Docs link, to avoid having to answer all the questions and than fail in a much later stage?

It would be more user friendly.

Comment 5 Simone Tiraboschi 2016-10-17 14:05:52 UTC

On my opinion, the point is that also force option in the createVG VDSM command is not forcefully enough.

In hosted-engine-setup we are not directly managing PVs since we are using a single vdsm command (createVG) to do it all so we cannot really trace where it internally fails.

If, as for bug 1343043, we don't want to fix that behavior but just handle it as a documentation issue (suggesting to manually remove the partition table), we could just add an initial warning reporting that also using the force option could be not enough and manually cleaning the selected lun could be required.

Comment 6 Yaniv Lavi 2016-11-22 13:36:56 UTC

KBase should do the trick. Closing.