Bug 1384345

+++ This bug was initially created as a clone of Bug #1222915 +++

+++ This bug was initially created as a clone of Bug #1222148 +++

glusterfsd/src/glusterfsd.c:215
        {"use-readdirp", ARGP_FUSE_USE_READDIRP_KEY, "BOOL", OPTION_ARG_OPTIONAL,
         "Use readdirp mode in fuse kernel module"
         " [default: \"off\"]"},


glusterfsd/src/glusterfsd.c:1077
        case ARGP_FUSE_USE_READDIRP_KEY:
                if (!arg)
                        arg = "yes";


The default should be yes anyway, so just need to fix the text in line 217

Even better would be to have these kind of options and their help text come from each translator's volume_options struct so changes don't come from multiple places. Perhaps that struct should be in include files?

--- Additional comment from Vijay Bellur on 2016-06-02 17:02:58 EDT ---

REVIEW: http://review.gluster.org/14622 (Corrected default text for ARGP_FUSE_USE_READDIRP_KEY Changed from "off" to "yes" per BZ 1222915) posted (#1) for review on master by Dustin Black (dblack)

--- Additional comment from Dustin Black on 2016-06-02 17:05:30 EDT ---

http://review.gluster.org/#/c/14622/

--- Additional comment from Vijay Bellur on 2016-06-06 11:01:45 EDT ---

COMMIT: http://review.gluster.org/14622 committed in master by Jeff Darcy (jdarcy) 
------
commit 66cc92c25ec2680e50a6b3edda2e027635c380db
Author: Dustin Black <dblack>
Date:   Thu Jun 2 17:01:32 2016 -0400

    Corrected default text for ARGP_FUSE_USE_READDIRP_KEY
    Changed from "off" to "yes" per BZ 1222915
    
    Change-Id: Idffffee621560adb4cc02c1001d1ae21ca11941f
    BUG: 1222915
    Signed-off-by: Dustin Black <dblack>
    Reviewed-on: http://review.gluster.org/14622
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Jeff Darcy <jdarcy>