Bug 1384451

Summary:	Expanded options by "Show options for secured routes" lost the way to hide them
Product:	OKD	Reporter:	XiaochuanWang <xiaocwan>
Component:	Management Console	Assignee:	Samuel Padgett <spadgett>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yadan Pei <yapei>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.x	CC:	aos-bugs, jforrest, mmccomas
Target Milestone:	---
Target Release:	3.x
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-07 18:12:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description XiaochuanWang 2016-10-13 10:02:26 UTC

Description of problem:
On create app from image, create route page and edit routes page, there is no way to hide the options after expand them by "Show options for secured routes"


Version-Release number of selected component (if applicable):
openshift v1.4.0-alpha.0+c728fe9(latest origin-web-console, latest commit is 03b49b4, manually vendored)
kubernetes v1.4.0+776c994
etcd 3.1.0-alpha.1

How reproducible:
Always

Steps to Reproduce:
1. Create a project and go to Applications -> Routes -> Create Route page
2. Check and click the link "Show options for secured routes"
3. Go back to project -> "Add to Project" -> select a app such as "php:56"
4. Expand the options by "Show advanced routing, build, and deployment options"
5. Check and click the "Show options for secured routes"

Actual results:
2. After clicked the link, there is no way to hide options for secured routes
5. Same as above

Expected results:
2. After clicked the link, there should be a link "Hide options for secured routes"
5. Same as above

Additional info:

Comment 1 Samuel Padgett 2016-10-13 13:21:09 UTC

What if there is a validation error for a field that's hidden?

What if I make a change in advanced options, then hide the options. Will my change be saved or reset?

I feel like there are a lot of potential usability problems with a hide advanced options link.

Comment 2 XiaochuanWang 2016-10-14 02:41:02 UTC

Just for a reference, please try directly the step3 and step4, here is hidden options by "Show advanced routing, build, and deployment options". Does it make senses for your concern? HDYT?

Error message highlights the field as soon as user input the invalid value. (eg. invalid value for routing hostname)
Then ignore it and hide the options, the field will reset to empty.

If there is a change in hidden options (gave a valid hostname for routing), hide it, the value shall be the same when it expand again.

Comment 3 Samuel Padgett 2016-10-14 12:03:54 UTC

(In reply to XiaochuanWang from comment #2)

> Error message highlights the field as soon as user input the invalid value.
> (eg. invalid value for routing hostname)
> Then ignore it and hide the options, the field will reset to empty.

As a user, I definitely wouldn't expect the field to be cleared. It seems bad to let the user type something, close the section, and click "Save" without it being saved...

If you edit a route with SSL enabled, we expand the advanced section on load so you can see what you're editing and saving. The section is only ever collapsed if the route doesn't have SSL.

Comment 4 Samuel Padgett 2016-10-14 14:35:49 UTC

@Jessica, maybe we should have a "secure route" checkbox rather than advanced link. If it's checked, show the additional route termination fields. If not, hide them.

Comment 5 Samuel Padgett 2016-10-24 13:05:20 UTC

https://github.com/openshift/origin-web-console/pull/708

Comment 6 Jessica Forrester 2017-06-22 14:13:54 UTC

origin bug, moving to ON_QA

Comment 7 XiaochuanWang 2017-06-26 02:23:02 UTC

Using "Secure route" check box for more options, this is verified on:
OpenShift Master:     v3.6.0-alpha.1+6acabdc-1064
Kubernetes Master:    v1.6.1+5115d708d7