Bug 1384471

Summary:	[DOCS] [3.4] Document the ability to add secrets to DC and BC for accessing private registries
Product:	OpenShift Container Platform	Reporter:	Vikram Goyal <vigoyal>
Component:	Documentation	Assignee:	Ashley Hardin <ahardin>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Xingxing Xia <xxia>
Severity:	high	Docs Contact:	Vikram Goyal <vigoyal>
Priority:	medium
Version:	3.4.0	CC:	ahardin, aos-bugs, jokerman, mmccomas, xxia
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-23 17:16:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Vikram Goyal 2016-10-13 10:56:26 UTC

As a user I want to add a secret to my Build config so it can access a private repository. As a user I want to add a secret to my Build config or Deployment Config so it can pull/push from/to a private registry.

Eng card: https://trello.com/c/OVlx3edX/691-5-add-secrets-to-bcs-dcs-for-private-repos-and-registries-ux-p3

Comment 3 Ashley Hardin 2016-11-01 20:23:12 UTC

Work in progress:
https://github.com/openshift/openshift-docs/pull/3145

Comment 4 Xingxing Xia 2016-12-21 03:43:40 UTC

Added one comment https://github.com/openshift/openshift-docs/pull/3145#issuecomment-268427807

Comment 5 Xingxing Xia 2016-12-21 08:25:21 UTC

More comment in PR: https://github.com/openshift/openshift-docs/pull/3145#issuecomment-268463130

Comment 6 Xingxing Xia 2016-12-27 02:29:48 UTC

As per previous comments 4 and 5, the doc PR doesn't LGTM yet. Waiting for update. Thx

Comment 8 Ashley Hardin 2017-01-06 23:36:34 UTC

Xingxing, I made updates per your comments. Please review again. Thank you!

Comment 9 Xingxing Xia 2017-01-09 06:49:08 UTC

Thanks! Added new comment in https://github.com/openshift/openshift-docs/pull/3145#pullrequestreview-15649717 , please check

Comment 10 Ashley Hardin 2017-01-09 19:49:56 UTC

Thank you! Comments addressed.

Comment 11 Xingxing Xia 2017-01-10 02:32:53 UTC

The PR LGTM now. Bug could be verified after PR is merged. Thx!

Comment 12 openshift-github-bot 2017-01-10 13:54:17 UTC

Commits pushed to master at https://github.com/openshift/openshift-docs

https://github.com/openshift/openshift-docs/commit/4007d4fab8b416aa61a88abafe0c00c27a4706aa
Bug 1384471, outlined adding secrets to BCs to access private repos

https://github.com/openshift/openshift-docs/commit/1a821a1dffc8db131c71f84909828a2dbd31e660
Merge pull request #3145 from ahardin-rh/secrets-private-repos

Bug 1384471, outlined adding secrets to BCs to access private repos

Comment 13 Ashley Hardin 2017-01-23 17:16:38 UTC

Content was published with the OCP 3.4 release:

https://access.redhat.com/documentation/en/openshift-container-platform/3.4/single/developer-guide/#adding-secrets-to-source-strategy-build-configs

https://access.redhat.com/documentation/en/openshift-container-platform/3.4/single/developer-guide/#adding-secrets-to-docker-strategy-build-configs

https://access.redhat.com/documentation/en/openshift-container-platform/3.4/single/developer-guide/#adding-secrets-to-custom-strategy-build-configs

https://access.redhat.com/documentation/en/openshift-container-platform/3.4/single/developer-guide/#adding-secrets-to-deployment-config