Bug 1384490

Summary: [ALL LANG] Validation messages on 'login' screen and 'Update password' screen are not localized
Product: Red Hat CloudForms Management Engine Reporter: Krishna Babu K <kkrothap>
Component: InternationalizationAssignee: Milan Zázrivec <mzazrivec>
Status: CLOSED CURRENTRELEASE QA Contact: Krishna Babu K <kkrothap>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.7.0CC: cpelland, jhardy, kkrothap, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, Translation
Target Release: 5.8.0   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1386772 (view as bug list) Environment:
Last Closed: 2017-06-12 17:32:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1386772    
Attachments:
Description Flags
Screen shot reference for the reported issue.
none
Screen shot reference for the reported issue.
none
Screen shot reference for the reported issue.
none
Screen shot reference for the reported issue. none

Description Krishna Babu K 2016-10-13 11:52:43 UTC
Created attachment 1210040 [details]
Screen shot reference for the reported issue.

Description of problem:
Validation messages are not localized on 'login' & 'Update password' screens.
These strings needs to be marked for translation:

1.Error: Name is required
2.Error: New password can not be blank
3.Error: New password and verify password must be the same
4.Error: New password is the same as existing password

Version-Release number of selected component (if applicable):
5.7.0.4-alpha1.20161005153002_cfc8a23 

How reproducible:
Always

Steps to Reproduce:
1. Access cfme login page either in ja_JP or zh_CN locale.

2. Keep both 'Username' & 'Password' fields empty and press 'login', the validation message 'Error: Name is required' is not localized.

3. Press 'Update password'. Keep 'Password', 'New Password' and 'Verify Password' fields empty and press 'login', validation message 'Error: New password can not be blank' is not localized.

3. Provide same values for 'Password', 'New Password' and 'Verify Password' and press 'login', validation message 'Error: New password is the same as existing password' is not localized.

4. Provide different values for 'New Password' and 'Verify Password' and press 'login', validation message 'Error: New password and verify password must be the same' is not localized.


Actual results:
Strings are not available for translation and hence translations are missing.

Expected results:
Strings should be marked for translation and translated.

Additional info:
I have searched for all four strings mentioned in the description at following locations where localizers working on translations.

1.https://translate.zanata.org/iteration/view/manageiq-ui-self_service/euwe/languages/ja?dswid=-9758
2.https://translate.zanata.org/iteration/view/manageiq/euwe/languages/ja?dswid=-365

Please make available missing strings for translation at the respective locations.

Comment 2 Krishna Babu K 2016-10-13 11:53:24 UTC
Created attachment 1210041 [details]
Screen shot reference for the reported issue.

Comment 3 Krishna Babu K 2016-10-13 11:54:03 UTC
Created attachment 1210042 [details]
Screen shot reference for the reported issue.

Comment 4 Krishna Babu K 2016-10-13 11:54:33 UTC
Created attachment 1210043 [details]
Screen shot reference for the reported issue.

Comment 5 Milan Zázrivec 2016-10-17 11:23:37 UTC
https://github.com/ManageIQ/manageiq/pull/11984

Comment 6 CFME Bot 2016-10-18 10:51:15 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/abc941a543896819f7f710502d0a30fb0a9eb612

commit abc941a543896819f7f710502d0a30fb0a9eb612
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Mon Oct 17 13:23:28 2016 +0200
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Mon Oct 17 13:23:28 2016 +0200

    Add missing gettext into UserValidationService
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1384490

 app/services/user_validation_service.rb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comment 7 CFME Bot 2016-10-19 03:27:20 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/167758d02488dcee73bf717a7504382c2dc30ed0

commit 167758d02488dcee73bf717a7504382c2dc30ed0
Author:     Oleg Barenboim <chessbyte>
AuthorDate: Tue Oct 18 05:46:16 2016 -0500
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Tue Oct 18 22:24:09 2016 -0500

    Merge pull request #11984 from mzazrivec/add_missing_gettext_into_user_validation_service
    
    Add missing gettext into UserValidationService
    (cherry picked from commit 5a6821ed5b725547dd20e5531eb7aad4f5189cb7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1384490

 app/services/user_validation_service.rb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comment 9 Krishna Babu K 2017-02-07 16:18:55 UTC
Verified on 5.8.0.0.20170201144150_848e68b 
Translations are available now.