Bug 1385236

Summary:	invalid argument warning messages seen in fuse client logs 2016-09-30 06:34:58.938667] W [dict.c:418ict_set] (-->/usr/lib64/glusterfs/3.8.4/xlator/cluster/replicate.so(+0x58722) 0-dict: !this \|\| !value for key=link-count [Invalid argument]
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs, nbalacha, nchilaka, rhs-bugs, storage-qa-internal, tdesala
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1385104
Clones:	1385442 (view as bug list)		Environment:
Last Closed:	2016-12-06 06:01:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1380710, 1385104
Bug Blocks:	1385442

Comment 1 Worker Ant 2016-10-15 14:20:26 UTC

REVIEW: http://review.gluster.org/15650 (cluster/afr: Prevent dict_set() on NULL dict) posted (#1) for review on release-3.9 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Worker Ant 2016-10-16 02:38:28 UTC

COMMIT: http://review.gluster.org/15650 committed in release-3.9 by Pranith Kumar Karampuri (pkarampu) 
------
commit 07d8f2b26071fa6c757190ce1a792e07d0d744b8
Author: Pranith Kumar K <pkarampu>
Date:   Fri Sep 30 17:16:43 2016 +0530

    cluster/afr: Prevent dict_set() on NULL dict
    
    In afr lookup when NULL dict is received in lookup, afr
    is supposed to set all the xattrs it requires in a new dict
    it creates, but for 'link-count' it is trying to set to the
    dict that is passed in lookup which can be NULL sometimes.
    This is leading to error logs. Fixed the same in this patch.
    
     >BUG: 1385104
     >Change-Id: I679af89cfc410cbc35557ae0691763a05eb5ed0e
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: http://review.gluster.org/15646
     >Smoke: Gluster Build System <jenkins.org>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >CentOS-regression: Gluster Build System <jenkins.org>
     >Reviewed-by: Ravishankar N <ravishankar>
    
    BUG: 1385236
    Change-Id: I802e74e7ad24e183b6653101ad7bf5ab0bf6e55b
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/15650
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>

Comment 3 Aravinda VK 2016-10-27 05:22:13 UTC

glusterfs-3.9.0rc2 is released[1] and packages are available for different distributions[2] to test.

[1] http://www.gluster.org/pipermail/maintainers/2016-October/001601.html
[2] http://www.gluster.org/pipermail/maintainers/2016-October/001605.html and http://www.gluster.org/pipermail/maintainers/2016-October/001606.html

Comment 4 Aravinda VK 2016-12-06 06:01:08 UTC

Gluster 3.9 GA is released http://blog.gluster.org/2016/11/announcing-gluster-3-9/