Bug 1385422

Summary:	[RFE] Shouldn't restart etcd unless there are configuration or packages changes
Product:	OpenShift Container Platform	Reporter:	Anping Li <anli>
Component:	Cluster Version Operator	Assignee:	Scott Dodson <sdodson>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Anping Li <anli>
Severity:	medium	Docs Contact:
Priority:	low
Version:	3.3.0	CC:	anli, aos-bugs, jokerman, mmccomas, sdodson
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-09 02:09:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Anping Li 2016-10-17 01:34:37 UTC

Description of problem:
During rpm upgrade, although there is no changes with etcd configure, the etcd service was still restarted, 
The upgrade should only restart service when there are packages or configuration changes.

Version-Release number of selected component (if applicable):
openshift-ansible-3.3.35-1.git

How reproducible:
always

Steps to Reproduce:
It is easy to reproduced by run upgrade playbook against the latest OCP. In Production Environment, the step is as below:

1. Install OSE 3.2 with external etcd.
2. Upgrade to OCP 3.3
   ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_3/upgrade.yml
3. Check the etcd service status.

Actual results:
etcd service was restarted.

Expected results:
etcd service won't be restarted

Additional info:

Comment 1 Scott Dodson 2017-02-09 19:37:47 UTC

Now that we're upgrading etcd on each upgrade it's incredibly likely that we don't actually need to restart etcd. Marking UpcomingRelease

Comment 2 Anping Li 2017-03-08 01:28:52 UTC

I have observed unnecessary restart during v3.5 and v3.5 testing. Could we say the bug is fixed?

Comment 3 Scott Dodson 2017-03-08 14:42:35 UTC

Anping, you mean you have or have not observed unnecessary restart?

Comment 4 Scott Dodson 2017-03-08 14:43:08 UTC

If not, then yes, lets CLOSED CURRENTRELEASE.

Comment 5 Anping Li 2017-03-09 02:08:57 UTC

Scott, Yes