Bug 1385442

Summary:	invalid argument warning messages seen in fuse client logs 2016-09-30 06:34:58.938667] W [dict.c:418ict_set] (-->/usr/lib64/glusterfs/3.8.4/xlator/cluster/replicate.so(+0x58722) 0-dict: !this \|\| !value for key=link-count [Invalid argument]
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs, nbalacha, nchilaka, rhs-bugs, storage-qa-internal, tdesala
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1385236	Environment:
Last Closed:	2016-11-29 09:36:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1380710, 1385104, 1385236
Bug Blocks:

Comment 1 Pranith Kumar K 2016-10-17 03:50:59 UTC

Steps to reproduce this:
1. Create a 2x2 volume. 
2. Fuse mount the volume and create dir1
3. Unmount volume
4. Delete dir1 manually on both bricks of any one replica set.
5. Mount the volume and do a lookup. DHT should see that the directory is missing and trigger a heal, causing this message to be logged.

Comment 2 Worker Ant 2016-10-17 03:54:15 UTC

REVIEW: http://review.gluster.org/15651 (cluster/afr: Prevent dict_set() on NULL dict) posted (#1) for review on release-3.8 by Pranith Kumar Karampuri (pkarampu)

Comment 3 Worker Ant 2016-10-17 10:04:51 UTC

COMMIT: http://review.gluster.org/15651 committed in release-3.8 by Pranith Kumar Karampuri (pkarampu) 
------
commit 1f4a350ed67b383ff7dd8c04c5b49ed0db2e7cb4
Author: Pranith Kumar K <pkarampu>
Date:   Fri Sep 30 17:16:43 2016 +0530

    cluster/afr: Prevent dict_set() on NULL dict
    
    In afr lookup when NULL dict is received in lookup, afr
    is supposed to set all the xattrs it requires in a new dict
    it creates, but for 'link-count' it is trying to set to the
    dict that is passed in lookup which can be NULL sometimes.
    This is leading to error logs. Fixed the same in this patch.
    
     >BUG: 1385104
     >Change-Id: I679af89cfc410cbc35557ae0691763a05eb5ed0e
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: http://review.gluster.org/15646
     >Smoke: Gluster Build System <jenkins.org>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >CentOS-regression: Gluster Build System <jenkins.org>
     >Reviewed-by: Ravishankar N <ravishankar>
    
     >BUG: 1385236
     >Change-Id: I802e74e7ad24e183b6653101ad7bf5ab0bf6e55b
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: http://review.gluster.org/15650
     >Smoke: Gluster Build System <jenkins.org>
     >CentOS-regression: Gluster Build System <jenkins.org>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >Reviewed-by: Ravishankar N <ravishankar>
    
    BUG: 1385442
    Change-Id: Ie93b25e8cf52b0d58ef335929dfa10a78a0dd734
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/15651
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>

Comment 4 Niels de Vos 2016-11-29 09:36:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.6, please open a new bug report.

glusterfs-3.8.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2016-November/000217.html
[2] https://www.gluster.org/pipermail/gluster-users/