Bug 1385549

Summary: dry-run feature UX improvements
Product: Red Hat Enterprise Linux 7 Reporter: Marek Haicman <mhaicman>
Component: scap-workbenchAssignee: Watson Yuuma Sato <wsato>
Status: CLOSED ERRATA QA Contact: Marek Haicman <mhaicman>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: lmiksik, mhaicman, mpreisle, openscap-maint
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: scap-workbench-1.1.4-4.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 09:09:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
new state none

Description Marek Haicman 2016-10-17 10:03:48 UTC 
Description
When selecting "Dry run" option in SCAP Workbench, there is no scan performed, only output is shell command line which will perform exactly same task, as the SCAP Workbench after clicking Scan button without dry run selected. But still, even after dry running, buttons are changed to "Clear, Save Results and Show Report", even though these options are of no use, as there was no scan performed.

Also I wonder if the "Scan" caption on the button is appropriate, when "Dry run" is selected, as it technically does not perform scan, not even a fake one. Maybe the best solution is to change "Dry run" checkbox for another button?

Reproduction steps:
1. open guide
2. tick "Dry run"
3. click "Scan" button
4. close commandline arguments dialog

Actual results
SCAP Workbench is in the post-scan state, Customization and Profile greyed out, "Clear" "Save Results" and "Show Results" buttons at the bottom

Expected results:
main window is not changed by clicking on the "Scan"/"Dry run" button
Comment 1 Watson Yuuma Sato 2016-12-07 16:59:44 UTC 
Thank you for the report,
This bug has been fixed upstream: https://github.com/OpenSCAP/scap-workbench/pull/93
Comment 4 Marek Haicman 2017-05-29 12:54:26 UTC 
Created attachment 1283220 [details]
new state

Verified for version
[dahaic@localhost ~]$ rpm -qa scap-workbench
scap-workbench-1.1.4-4.el7.x86_64

As shown on attached screenshot, buttons of the main window do not change by performing dry run query.
Comment 5 errata-xmlrpc 2017-08-01 09:09:29 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2296