Bug 1385856

+++ This bug was initially created as a clone of Bug #1196920 +++

Spec URL: 
https://guidograzioli.fedorapeople.org/packages/log4shib/log4shib.spec

SRPM URL: 
https://guidograzioli.fedorapeople.org/packages/log4shib/log4shib-1.0.9-1.fc23.src.rpm

Description: 
log4shib is a forked version of log4cpp that has been created for the
Shibboleth project to ensure a consistent, working snapshot that builds
reliably on the necessary platforms.

Fedora Account System Username:guidograzioli

Additional info:
opensaml build is currently (2.4.3) falling back to using log4cpp; for updating to opensaml 2.5.3 (xmltooling 1.5.3) this package becomes necessary.

--- Additional comment from Michael Schwendt on 2015-03-11 12:55:50 CET ---

> Name:           log4shib
> Group:          Development/Libraries

Runtime library base packages have been in group "System Environment/Libraries" for many years. The group "Development/Libraries" is for the separate build-time -devel packages.

Nowadays, the Group tag is optional, however:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

Reusing a Fedora spec file for EL is not always a good idea, since differences in updates and rebuilds introduce a lot of irrelevant crap in the %changelog.


> BuildRequires:  gcc-c++

JFYI, it is not necessary yet to add this.
https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2


> %package doc
> Summary:        Development documentation for %{name}
> Group:          Development/Libraries

If at all, it would be group "Documentation".


> Requires:       %{name}%{?_isa} = %{version}-%{release}

Although the guidelines don't cover it [yet], documentation packages ought to stay free of such unnecessary dependencies. It should be possible to install documentation packages without pulling in unneeded runtime libs and other dependencies. That is especially true, if the documentation does not need the base package to be displayed/viewed by the user.


> # Packages are not supposed to add %optflags or %__global_ldflags to *.pcs
> sed -i -e "s|%{optflags}||;s|%{__global_ldflags}||" %{name}.pc

This will require a second look as I've only skimmed over the spec file. It would be good if the .pc did not add any other unnecessary stuff to CFLAGS/LDFLAGS.


> %files
> %defattr(-, root, root, 0755)

Superfluous. %defattr is not necessary anymore for a long time, and a change from the default (-,root,root,-) would need to be explained:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


> %doc ChangeLog 

There are a couple of other plain text doc files. Why not include them?


> %{_bindir}/log4shib-config

This will need to be checked for multilib conflicts as well as for inserted CFLAGS/LDFLAGS just like the .pc file.  In case there is a conflict, a common work-around is to have the script query pkg-config instead of redefining paths/values itself.

--- Additional comment from Guido Grazioli on 2015-03-11 14:12:00 CET ---

(In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #1)

aaargh, apologies for having been lazy; I didn't handle a new package for quite some time (ie years) so I'd thought that stealing from the log4cpp spec would have been a nice way to avoid to go thru the guidelines again. I'll address the issues shortly, thanks for your time.

--- Additional comment from Raphael Groner (DAASI International) on 2016-08-08 09:51:07 CEST ---

Any news here?

--- Additional comment from Raphael Groner on 2016-10-03 13:44:46 CEST ---

Friendly reminder. Are you still interested in this package?

--- Additional comment from Guido Grazioli on 2016-10-17 14:44:42 CEST ---

No.

--- Additional comment from Raphael Groner on 2016-10-17 20:45:40 CEST ---

This library is needed to update shibboleth stack, I'll take over here.