Bug 1386338

Summary:	pmap_signin event fails to update brickinfo->signed_in flag
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	Atin Mukherjee <amukherj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1385575
Clones:	1386538 (view as bug list)		Environment:
Last Closed:	2016-12-06 06:00:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1385575
Bug Blocks:	1386538

Description Atin Mukherjee 2016-10-18 17:34:20 UTC

+++ This bug was initially created as a clone of Bug #1385575 +++

Description of problem:

While testing gluster get-state CLI, we figured out that brickinfo->signed_in field of a given brick of a volume is marked as false even if the pmap_signin has successfully happened. 

Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-10-17 06:46:22 EDT ---

REVIEW: http://review.gluster.org/15655 (glusterd: set the brickinfo->port before spawning the bricks) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2016-10-18 10:16:21 EDT ---

COMMIT: http://review.gluster.org/15655 committed in master by Jeff Darcy (jdarcy) 
------
commit bac42476a14a16089e7185c7a250dfae43be6106
Author: Atin Mukherjee <amukherj>
Date:   Mon Oct 17 16:08:41 2016 +0530

    glusterd: set the brickinfo->port before spawning the bricks
    
    As of now, when glusterd spawns a brick process, post spawning, the brickinfo's
    port is set. The side effect of this is it opens up an window where the
    pmap_signin event can be initiated by the brick to glusterd and glusterd fails
    to update signed_in flag since the brickinfo port is still 0 and the comparison
    of port and brickinfo->port fails.
    
    As a solution, set the brickinfo->port post pmap_registry_alloc and if the brick
    spawn fails reset it to 0. This logic applies for rdma port too.
    
    Change-Id: I00a13d4c6d6809ebd19a972aa13e71ee5eac7e35
    BUG: 1385575
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/15655
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Samikshan Bairagya <samikshan>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 1 Worker Ant 2016-10-19 08:30:59 UTC

REVIEW: http://review.gluster.org/15679 (glusterd: set the brickinfo->port before spawning the bricks) posted (#1) for review on release-3.9 by Atin Mukherjee (amukherj)

Comment 2 Worker Ant 2016-10-21 09:17:17 UTC

COMMIT: http://review.gluster.org/15679 committed in release-3.9 by Atin Mukherjee (amukherj) 
------
commit 1e6db41c3a1969474ad6a6831815b0c0de378877
Author: Atin Mukherjee <amukherj>
Date:   Mon Oct 17 16:08:41 2016 +0530

    glusterd: set the brickinfo->port before spawning the bricks
    
    As of now, when glusterd spawns a brick process, post spawning, the brickinfo's
    port is set. The side effect of this is it opens up an window where the
    pmap_signin event can be initiated by the brick to glusterd and glusterd fails
    to update signed_in flag since the brickinfo port is still 0 and the comparison
    of port and brickinfo->port fails.
    
    As a solution, set the brickinfo->port post pmap_registry_alloc and if the brick
    spawn fails reset it to 0. This logic applies for rdma port too.
    
    >Reviewed-on: http://review.gluster.org/15655
    >Smoke: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Samikshan Bairagya <samikshan>
    >Reviewed-by: Jeff Darcy <jdarcy>
    
    Change-Id: I00a13d4c6d6809ebd19a972aa13e71ee5eac7e35
    BUG: 1386338
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/15679
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Samikshan Bairagya <samikshan>

Comment 3 Aravinda VK 2016-10-27 05:22:51 UTC

glusterfs-3.9.0rc2 is released[1] and packages are available for different distributions[2] to test.

[1] http://www.gluster.org/pipermail/maintainers/2016-October/001601.html
[2] http://www.gluster.org/pipermail/maintainers/2016-October/001605.html and http://www.gluster.org/pipermail/maintainers/2016-October/001606.html

Comment 4 Aravinda VK 2016-12-06 06:00:43 UTC

Gluster 3.9 GA is released http://blog.gluster.org/2016/11/announcing-gluster-3-9/