Bug 1386535

Summary: wrong version of template is installed by ansible
Product: OpenShift Container Platform Reporter: Alexander Koksharov <akokshar>
Component: InstallerAssignee: Scott Dodson <sdodson>
Status: CLOSED CURRENTRELEASE QA Contact: Gan Huang <ghuang>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: akokshar, aos-bugs, jdetiber, jokerman, mmccomas
Target Milestone: ---Flags: akokshar: needinfo? (jdetiber)
akokshar: needinfo? (jdetiber)
akokshar: needinfo? (jdetiber)
akokshar: needinfo? (jdetiber)
Target Release: 3.3.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-31 12:30:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Alexander Koksharov 2016-10-19 08:29:29 UTC
Description of problem:

Install playbook was executed from a dedicated host.
openshift selects 1.2 instead of 1.3 when installing openshift with ansible-playbook

The was worked around by modifying /usr/share/ansible/openshift-ansible/roles/openshift_facts/library/openshift_facts.py l841.
Value was changed from False to true.

 824         version = get_openshift_version(facts)
 825         if version:
     .....
 837         else:   
 838             version_gte_3_1_or_1_1 = True
 839             version_gte_3_1_1_or_1_1_1 = True
 840             version_gte_3_2_or_1_2 = True
 841             version_gte_3_3_or_1_3 = False

Line modified is in section which is used if "version" is not yet set.
"version" is returned by get_openshift_version which is checking version with "module.run_command(['/usr/bin/openshift', 'version'])".

On what host this command is being executed by the installer? 


Version-Release number of selected component (if applicable):
3.3

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Scott Dodson 2016-10-26 21:14:55 UTC
I've seen this before with a containerized install, is this a containerized install?

Comment 4 Scott Dodson 2017-02-10 01:51:34 UTC
https://github.com/openshift/openshift-ansible/pull/3324 proposed fix

Comment 5 Scott Dodson 2017-03-30 14:55:28 UTC
Please test with the latest 3.3 installer, this is believed to have been fixed in the pr from comment 4.

Comment 6 Gan Huang 2017-03-31 10:13:08 UTC
Reproduced with openshift-ansible-3.3.28-1.git.0.762256b.el7.noarch.rpm

master/node configurations are created correctly in openshift-ansible-3.3.68-1.git.0.3792453.el7.noarch.rpm

# cat /etc/origin/master/master-config.yaml
<--snip-->
controllerConfig:
  serviceServingCert:
    signer:
      certFile: service-signer.crt
      keyFile: service-signer.key
<--snip-->
masterClients:
  externalKubernetesClientConnectionOverrides:
    acceptContentTypes: application/vnd.kubernetes.protobuf,application/json
    contentType: application/vnd.kubernetes.protobuf
    burst: 400
    qps: 200
  externalKubernetesKubeConfig: ""
  openshiftLoopbackClientConnectionOverrides:
    acceptContentTypes: application/vnd.kubernetes.protobuf,application/json
    contentType: application/vnd.kubernetes.protobuf
    burst: 600
    qps: 300
<--snip-->

# cat /etc/origin/node/node-config.yaml
<--snip-->
masterClientConnectionOverrides:
  acceptContentTypes: application/vnd.kubernetes.protobuf,application/json
  contentType: application/vnd.kubernetes.protobuf
  burst: 200
  qps: 100
<--snip-->

Move to verified.

Comment 7 Scott Dodson 2017-03-31 12:30:28 UTC
This was fixed in openshift-ansible-3.3.67-1.git.0.7c5da0c.el7 which shipped a month ago. Closing this.