Bug 1387098
| Summary: | [Eventing]: TIER_ATTACH_FORCE event not seen after 'gluster volume tier <volname> attach force' | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Sweta Anandpara <sanandpa> |
| Component: | eventsapi | Assignee: | Milind Changire <mchangir> |
| Status: | CLOSED WONTFIX | QA Contact: | storage-qa-internal <storage-qa-internal> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rhgs-3.2 | CC: | amukherj, dlambrig, mchangir, sanandpa, vbellur |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-07 13:05:14 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sweta Anandpara
2016-10-20 06:03:29 UTC
Sweta - We now have eventsapi component created, please use this component to file all eventing bugs. Commands attach-tier and detach-tier are deprecated. You will not see tier events if you use these commands. Please use "tier <vol> attach" and "tier <vol> detach". (In reply to Milind Changire from comment #3) > Commands attach-tier and detach-tier are deprecated. You will not see tier > events if you use these commands. > > Please use "tier <vol> attach" and "tier <vol> detach". Are they deprecated or going to be deprecated? In former, how are we allowing the command to go through? Deprecated implies something that is disapproved, not necessarily unavailable. Deprecated implies something that may be unavailable in the future. For reference: https://en.wikipedia.org/wiki/Deprecation I second Atin's concern. If they are deprecated, then: - are we disallowing the users to NOT use the command, by error'ing out with the message that this command is no longer valid? OR - are we printing out a warning message saying that 'these commands are deprecated, and no longer considered safe to see the intended behaviour'? When I check in 3.8.4-2 rpm bits, we are doing neither of the above. If the idea of deprecation is in-the-books (admin guide) - that does not come across to be sufficient. As per the user, if the command is seen, it exists -> if it exists and does not error out, it works -> if it works, an event should be seen. I am sure there must be a tiering BZ for tracking removal of support for 'gluster volume attach-tier' and 'gluster volume detach-tier'. Is that targeted for 3.2? If it is, we can rest on that front and move this BZ to its closure. If that is not targeted for 3.2, we are going to be shipping a release with the above commands very much functional. And if they are functional, we would need events to be supported in them. I don't think we can deprecate (disable the old CLI semantics) the CLI right away, it would require some effort. For now, can we do the following? Add an warning message mentioning this CLI will be deprecated and asked for a confirmation before proceeding (this needs a BZ though)? With that there would be a right message going towards the user discouraging to use it and in that case we need not to generate events? Sweta, Milind - Thoughts? I can see the following in mainline master bits ...
# gluster volume help
...
volume attach-tier <VOLNAME> [<replica COUNT>] <NEW-BRICK>... - NOTE: this is old syntax, will be depreciated in next release. Please use gluster volume tier <vol> attach [<replica COUNT>] <NEW-BRICK>...
...
volume detach-tier <VOLNAME> <start|stop|status|commit|force> - NOTE: this is old syntax, will be depreciated in next release. Please use gluster volume tier <vol> detach {start|stop|commit} [force]
-----
However, the help text for attach-tier and detach-tier does not mention that these commands are deprecated. Maybe the engineer missed adding the deprecation text here.
This behavior is nothing new in mainline master as of today and should be seen with glusterfs-3.8.4-2 bits as well.
According to git blame, the deprecation text was added by Dan on 2015-08-21 06:45:46 -0400.
Yes, adding the above note (mentioned in comment 9) in the help text of 'gluster volume attach-tier' and 'gluster volume detach-tier' AND A confirmatory message (when the command is triggered) asking the user 'if he would really want to go ahead with a _deprecated_ command' should be sufficient to discourage the user from trying out these. And if he/she still chooses to go ahead in the forbidden path, it is okay for events to not be seen. Sounds fair. P.S. Just curious, is it a significant-code-change/substantial-effort to add eventing support in the code-path of above commands? (In reply to Sweta Anandpara from comment #10) > Yes, adding the above note (mentioned in comment 9) in the help text of > 'gluster volume attach-tier' and 'gluster volume detach-tier' > AND > A confirmatory message (when the command is triggered) asking the user 'if > he would really want to go ahead with a _deprecated_ command' > > should be sufficient to discourage the user from trying out these. And if > he/she still chooses to go ahead in the forbidden path, it is okay for > events to not be seen. Sounds fair. > > > > P.S. > Just curious, is it a significant-code-change/substantial-effort to add > eventing support in the code-path of above commands? My only concern is to add events in this release and then take them out in next given they are no longer valid, that's a waste of an effort to me. This bug can be closed as won't fix once BZ 1388464 is fixed. Given BZ 1388464 is now been fixed, closing this bug. |