Bug 1387477
Summary: | virtual interface offload for virtio - disable host ufo only will not work | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | yalzhang <yalzhang> |
Component: | qemu-kvm-rhev | Assignee: | Wei <wexu> |
Status: | CLOSED NOTABUG | QA Contact: | Virtualization Bugs <virt-bugs> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 7.4 | CC: | ailan, chayang, jasowang, juzhang, knoel, virt-maint, weliao, wexu, yalzhang |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-12-08 12:07:17 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
yalzhang@redhat.com
2016-10-21 02:12:38 UTC
Yal, I have tried it with upstream, it doesn't work even with your step 3, can you share your test machine with me? My cases: -device virtio-net-pci,host_ufo=off,gso=off,guest_ufo=off,netdev=hn1,mac=52:54:00:11:22:10 -device virtio-net-pci,host_ufo=off,guest_ufo=off,netdev=hn1,mac=52:54:00:11:22:10 -device virtio-net-pci,guest_ufo=off,netdev=hn1,mac=52:54:00:11:22:10 \ BTW, can you add me to the cc list of bug 1139364 as well? Seems I don't have permission to access the bz. Just noticed you were using 'gso=on', also tried that, not working for upstream. -device virtio-net-pci,host_ufo=off,gso=on,guest_ufo=off,netdev=hn1,mac=52:54:00:11:22:10 \ -device virtio-net-pci,host_ufo=off,gso=off,guest_ufo=off,netdev=hn1,mac=52:54:00:11:22:10 \ -device virtio-net-pci,host_ufo=off,guest_ufo=off,netdev=hn1,mac=52:54:00:11:22:10 \ -device virtio-net-pci,guest_ufo=on,netdev=hn1,mac=52:54:00:11:22:10 \ -device virtio-net-pci,guest_ufo=off,netdev=hn1,mac=52:54:00:11:22:10 \ A bit correction, ufo can only be turned off via 'host_ufo=off,gso=off,guest_ufo=off'. From guest's point of view, 'ufo' depends on gso, ufo will turned on if gso has been enabled. For host side, ufo depends on host ufo as well. Looks this is by design when probing virtio net device in guest, thus it is not a bug. if (virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) { dev->hw_features |= NETIF_F_TSO | NETIF_F_UFO | NETIF_F_TSO_ECN | NETIF_F_TSO6; } /* Individual feature bits: what can host handle? */ if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_TSO4)) dev->hw_features |= NETIF_F_TSO; if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_TSO6)) dev->hw_features |= NETIF_F_TSO6; if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_ECN)) dev->hw_features |= NETIF_F_TSO_ECN; if (virtio_has_feature(vdev, VIRTIO_NET_F_HOST_UFO)) dev->hw_features |= NETIF_F_UFO; Yes, this looks not like a bug. If you're checking guest ufo (TX) through ethtool, it has nothing to do with guest_ufo (RX). Many thanks to jason and Wei, I think I got the meaning. It is not a bug but a wrong usage, it is something about the principle of GSO/TSO/UFO. If I want to disable ufo for the guest(both transmit and receive), I should set gso=off together, the xml should like this: <driver> <host gso='off' ufo='off'/> ===> for receive <guest ufo='off'/> ====> for transmit </driver> If I want to disable tcp related segments for guest, the xml should be like: <driver> <host gso='off' tso4='off' tso6='off' ecn='off'/> ===> for receive <guest tso4='off' tso6='off' ecn='off'/> ====> for transmit </driver> Both of them should include the "gso='off'" because tso and gso all depends on gso. Please help to check if I get the point, thank you very much! that is it. |