Bug 1387604

Summary:	Review Request: perl-Filter-Encoding - Write your script in any encoding
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Filter-Encoding-0.01-1.fc26	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-26 08:45:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2016-10-21 11:13:45 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Filter-Encoding/perl-Filter-Encoding.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Filter-Encoding/perl-Filter-Encoding-0.01-1.fc26.src.rpm
Description:
This module allows your code to be written in any ASCII-based encoding.
Just pass the name of the encoding as an argument to use Filter::Encoding.
The source code will be decoded and treated as though it had been written
in UTF-8 with use utf8 in effect. That's all this module does.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-10-24 10:30:34 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Filter-Encoding-0.01-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(Encode)
      1 perl(Filter::Util::Call)
      1 perl(utf8)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Filter-Encoding-0.01-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Filter::Encoding) = 0.01
      1 perl-Filter-Encoding = 0.01-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Filter-Encoding*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
APPROVED

Comment 2 Gwyn Ciesla 2016-10-24 14:43:15 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Filter-Encoding

Comment 3 Petr Pisar 2016-10-26 08:45:45 UTC

Thank you for the review and the repository.