Bug 1387619

Summary: Review Request: perl-Test-Is - Skip test in a declarative way
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Test-Is-20140823.1-1.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-26 08:51:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1387626    

Description Petr Pisar 2016-10-21 11:50:39 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Test-Is/perl-Test-Is.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test-Is/perl-Test-Is-20140823.1-1.fc26.src.rpm
Description:
This module is a simple way of following the specifications of the
environment variables available for Perl tests as defined as one of
the "Lancaster Consensus" at Perl QA Hackathon 2013. Those variables
(NONINTERACTIVE_TESTING, EXTENDED_TESTING) define which tests should
be skipped.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2016-10-24 11:41:16 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-Is-20140823.1-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) < 6
      1 perl(:VERSION) >= 5
      1 perl(Test::More) >= 0.88
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Is-20140823.1-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Test::Is) = 20140823.1
      1 perl-Test-Is = 20140823.1-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Test-Is*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
APPROVED
Comment 2 Gwyn Ciesla 2016-10-24 14:43:38 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Is
Comment 3 Petr Pisar 2016-10-26 08:51:59 UTC 
Thank you for the review and the repository.