Bug 1387837 (python-hidapi)

Package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 10 files have unknown license. Detailed
     output of licensecheck in /home/sagitter/1387837-python-
     hidapi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-hidapi , python3-hidapi , python-hidapi-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.

python tests executed but not performed.

[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-hidapi-0.7.99.post19-0.1.fc26.x86_64.rpm
          python3-hidapi-0.7.99.post19-0.1.fc26.x86_64.rpm
          python-hidapi-debuginfo-0.7.99.post19-0.1.fc26.x86_64.rpm
          python-hidapi-0.7.99.post19-0.1.fc26.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (debuginfo)
-------------------
Checking: python-hidapi-debuginfo-0.7.99.post19-0.1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
3 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
python3-hidapi (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libpthread.so.0()(64bit)
    libpython3.5m.so.1.0()(64bit)
    librt.so.1()(64bit)
    libudev.so.1()(64bit)
    libudev.so.1(LIBUDEV_183)(64bit)
    libusb-1.0.so.0()(64bit)
    python(abi)
    rtld(GNU_HASH)

python2-hidapi (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    librt.so.1()(64bit)
    libudev.so.1()(64bit)
    libudev.so.1(LIBUDEV_183)(64bit)
    libusb-1.0.so.0()(64bit)
    python(abi)
    rtld(GNU_HASH)

python-hidapi-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
python3-hidapi:
    python3-hidapi
    python3-hidapi(x86-64)
    python3.5dist(hidapi)
    python3dist(hidapi)

python2-hidapi:
    python-hidapi
    python-hidapi(x86-64)
    python2-hidapi
    python2-hidapi(x86-64)
    python2.7dist(hidapi)
    python2dist(hidapi)

python-hidapi-debuginfo:
    python-hidapi-debuginfo
    python-hidapi-debuginfo(x86-64)



Unversioned so-files
--------------------
python2-hidapi: /usr/lib64/python2.7/site-packages/hid.so
python2-hidapi: /usr/lib64/python2.7/site-packages/hidraw.so
python3-hidapi: /usr/lib64/python3.5/site-packages/hid.cpython-35m-x86_64-linux-gnu.so
python3-hidapi: /usr/lib64/python3.5/site-packages/hidraw.cpython-35m-x86_64-linux-gnu.so

Source checksums
----------------
https://raw.githubusercontent.com/trezor/cython-hidapi/master/LICENSE-bsd.txt#/python-hidapi-LICENSE-bsd.txt :
  CHECKSUM(SHA256) this package     : 5b4ef7439d2f82a2af57f1fb4a90366dd888a3d56444e5835441dd17ff31c716
  CHECKSUM(SHA256) upstream package : 5b4ef7439d2f82a2af57f1fb4a90366dd888a3d56444e5835441dd17ff31c716
https://raw.githubusercontent.com/trezor/cython-hidapi/master/LICENSE-gpl3.txt#/python-hidapi-LICENSE-gpl3.txt :
  CHECKSUM(SHA256) this package     : 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903
  CHECKSUM(SHA256) upstream package : 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903
https://files.pythonhosted.org/packages/source/h/hidapi/hidapi-0.7.99.post19.tar.gz :
  CHECKSUM(SHA256) this package     : 890dea8bd8c4d35e1f1b29a9a3431aa1ee79ee1baf86cacb5913983a5bec5689
  CHECKSUM(SHA256) upstream package : 890dea8bd8c4d35e1f1b29a9a3431aa1ee79ee1baf86cacb5913983a5bec5689
https://raw.githubusercontent.com/trezor/cython-hidapi/master/LICENSE.txt#/python-hidapi-LICENSE.txt :
  CHECKSUM(SHA256) this package     : 276c1c27bbaa34fd62f4e92ad7cf9f7f8f193c0440c9da86c389de0dae192f47
  CHECKSUM(SHA256) upstream package : 276c1c27bbaa34fd62f4e92ad7cf9f7f8f193c0440c9da86c389de0dae192f47
https://raw.githubusercontent.com/trezor/cython-hidapi/master/LICENSE-orig.txt#/python-hidapi-LICENSE-orig.txt :
  CHECKSUM(SHA256) this package     : e632cd50f8ebcef7192176d676c1e7c053a64fef91e9b62594e921589067a6e9
  CHECKSUM(SHA256) upstream package : e632cd50f8ebcef7192176d676c1e7c053a64fef91e9b62594e921589067a6e9


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1387837
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Thank you for the quick review, Antonio!  =)

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-hidapi

python-hidapi-0.7.99.post19-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e34683045

python-hidapi-0.7.99.post19-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-22c2b6eaab

python-binstruct-1.0.1-1.fc24, python-bitstruct-3.3.1-1.fc24, python-evic-0.1-0.4.git20160814.f916017.fc24, python-hidapi-0.7.99.post19-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e34683045

python-binstruct-1.0.1-1.fc25, python-bitstruct-3.3.1-1.fc25, python-evic-0.1-0.4.git20160814.f916017.fc25, python-hidapi-0.7.99.post19-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-22c2b6eaab

python-binstruct-1.0.1-1.fc24, python-bitstruct-3.3.1-1.fc24, python-evic-0.1-0.4.git20160814.f916017.fc24, python-hidapi-0.7.99.post20-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e34683045

python-binstruct-1.0.1-1.fc25, python-bitstruct-3.3.1-1.fc25, python-evic-0.1-0.4.git20160814.f916017.fc25, python-hidapi-0.7.99.post19-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

python-binstruct-1.0.1-1.fc24, python-bitstruct-3.3.1-1.fc24, python-evic-0.1-0.4.git20160814.f916017.fc24, python-hidapi-0.7.99.post20-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.