Bug 1387838

Description of problem:
Trying to import VMs from a KVM node using a URI like this: qemu+tcp://vmserver2-safari/system, Required Authentication unchecked, and nothing entered in user and password field. I have set libvirtd on the KVM end to use tcp with no authentication. Verified connection works.

However, receive these errors when I picked a VM to import:

2016-10-22 09 (tel:2016102209):49:29,300 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (pool-7-thread-2) [d38191] Correlation ID: d38191, Call Stack: null, Custom Event ID: -1, Message: Starting to convert Vm ks-safari
2016-10-22 09 (tel:2016102209):49:52,846 INFO [org.ovirt.engine.core.bll.exportimport.ConvertVmCallback] (DefaultQuartzScheduler1) [76a0f17f] Conversion of VM from exteral enironment failed: must be string or buffer, not None

After looking at the log more closely, and search the net for the  ConvertVmVDSCommand, I cam to this: 

https://gerrit.ovirt.org/#/c/33055/100..100/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConvertVmVDSCommand.java

@Override
protected void executeVdsBrokerCommand() {
status = getBroker().convertVmFromExternalSystem(
getParameters().getUrl(),
getParameters().getUsername(),
getParameters().getPassword(),
createVmProperties(),
getParameters().getVmId().toString());

So, I thought let me try again and leave "Required Authentication" checked, and enter a user and password, even though libvirtd on the KVM side doesn't need user/password. A wild guess, and but this workaround worked.

Also noticed there are couple of typos in the error message:

"Conversion of VM from exteral enironment failed: must be string or buffer, not None"


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1.Go to Virtual Machines
2.Select Import
3.Select Source KVM (via Libvirt)
4.Enter a URI like this: qemu+tcp://vmserver2-safari/system
5. Uncheck "Required password" and leave user and password fields blank.
6. The KVM end has to be set up to allow tcp, and none for authentication.
7. Click Load
8. Pick a VM to import
9. Error occurs after a few minutes. 

Actual results:
The Alert screen on the GUI shows this "Failed to import Vm ks-safari to Data Center Safari_Lab, Cluster Default"

Expected results:
VM gets imported after disk image get copied and converted.

Additional info:
It should detect that "Required Authentication" is unchecked, and therefore handler the blank user and password fields properly.