Bug 1387860
| Summary: | Error message when the atomic command is used with bash-completion | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lukas Slebodnik <lslebodn> |
| Component: | atomic | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 25 | CC: | adimania, amurdaca, dustymabe, dwalsh, gscrivan, lsm5, walters |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | atomic-1.16.4-1.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-01 17:10:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lukas Slebodnik
2016-10-22 17:02:29 UTC
was this working with previous atomic versions? seems like atomic never shipped/owned this "directory" as part of %files in the atomic.spec (In reply to Antonio Murdaca from comment #1) > was this working with previous atomic versions? seems like atomic never > shipped/owned this "directory" as part of %files in the atomic.spec Previously, I did not see the error "ls: cannot access '/var/lib/containers/atomic/': No such file or directory" Antonio could you add that directory to the atomic spec file. We should create it on install and own it in the spec file. I guess we should also own /var/lib/containers Thanks, having that /var/lib/containers be owned by skopeo is probably better. Sure, at this point though, we'll have the following situation: Skopeo-containers owns /var/lib/containers Is it possible to ship /var/lib/containers/atomic as part of atomic.spec or does this need to be owned by skopeo-containers as well? I see no issues in having skopeo-containers ship that as well. I think the bash autocompletion should check that the directory exists before trying to access it. I have submitted a PR to address it: https://github.com/projectatomic/atomic/pull/722 Yes but atomic should own the directory. We should ship with it. skopeo should not know about this directory. Lokesh I am about to create atomic-1.13.2, could you also fix the spec file when we ship this version. Problematic directories are not owned by any package and they do not exist. sh# rpm -qf /var/lib/containers/atomic/ error: file /var/lib/containers/atomic: No such file or directory sh# rpm -qf /var/lib/containers/ error: file /var/lib/containers: No such file or directory But I cannot reproduce issue with bash-completion with atomic-1.14.0-3.dev.git127d5a0.fc26.x86_64. Could you set proper version into the field "Fixed In Version" and close the bug? Fixed in atomic-1.14.0 working on this now, so atomic should own /var/lib/containers and /var/lib/containers/atomic, correct? Yes. atomic-1.15.3-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1def5655ad atomic-1.15.3-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1def5655ad atomic-1.16.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2ad6948192 atomic-1.16.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2ad6948192 atomic-1.16.4-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e8cbc792c6 atomic-1.16.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e8cbc792c6 atomic-1.16.4-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |