Bug 1387964

Description of problem:
========================
When we pause/resume the bitrot scrubber, it generates an event BITROT_SCRUB_OPTION, as there is a change in the scrub option. Similarly when we change the frequency to hourly/daily/weekly, it again generates an event BITROT_SCRUB_FREQ, as there is a change in the scrub frequency. Likewise, if we trigger the scrubber on demand, it necessitates a change in the system, thus producing an event. However, no event is generated/seen when the scrubber is triggered ondemand.


Version-Release number of selected component (if applicable):
============================================================


How reproducible:
=================
Always


Steps to Reproduce:
====================
1. Have a 4 node cluster, with a plain distribute volume. Enable eventing, and register a webhook, as a listener.
2. Create a volume 'vol1' and start it. The corresponding events are seen, as expected
3. Enable bitrot, change the scrub frequency and also try to pause/resume. Watch out for the related events BITROT_ENABLE, BITROT_SCRUB_FREQ, BITROT_SCRUB_OPTION. 
4. Trigger the scrubber on demand, and monitor if the event BITROT_SCRUB_OPTION is seen

Actual results:
==============
All expected events seen from step1 to 3. No event seen at step4

Expected results:
================
An event is expected at step4

REVIEW: http://review.gluster.org/15705 (bitrot/cli: Add ondemand scrub event) posted (#1) for review on release-3.9 by Kotresh HR (khiremat)

COMMIT: http://review.gluster.org/15705 committed in release-3.9 by Aravinda VK (avishwan) 
------
commit f1a0da5bfd7dfb6122fe92e45542960775904391
Author: Kotresh HR <khiremat>
Date:   Sat Oct 22 23:50:02 2016 +0530

    bitrot/cli: Add ondemand scrub event
    
    Following Bitrot Events are added
    
    BITROT_SCRUB_ONDEMAND
    {
         "nodeid": NODEID,
         "ts": TIMESTAMP,
         "event": EVENT_TYPE,
         "message": {
            "name": VOLUME_NAME,
         }
    }
    
    > Change-Id: I85e668e254e6f29c447ddb4ad2ce2fc04f98bf3c
    > BUG: 1387864
    > Signed-off-by: Kotresh HR <khiremat>
    > Reviewed-on: http://review.gluster.org/15700
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    
    Change-Id: I85e668e254e6f29c447ddb4ad2ce2fc04f98bf3c
    BUG: 1387964
    Signed-off-by: Kotresh HR <khiremat>
    (cherry picked from commit 255cc64375abe2925c7da1e13e45018dad4462df)
    Reviewed-on: http://review.gluster.org/15705
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Aravinda VK <avishwan>

glusterfs-3.9.0rc2 is released[1] and packages are available for different distributions[2] to test.

[1] http://www.gluster.org/pipermail/maintainers/2016-October/001601.html
[2] http://www.gluster.org/pipermail/maintainers/2016-October/001605.html and http://www.gluster.org/pipermail/maintainers/2016-October/001606.html

Gluster 3.9 GA is released http://blog.gluster.org/2016/11/announcing-gluster-3-9/