Bug 1388041

Summary: [userinterface_public_797]When changing deployment strategy type with advanced options expanded and selected not to keep paramaters, Lifehook is not completely cleared
Product: OKD Reporter: Yadan Pei <yapei>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.xCC: aos-bugs, jforrest, jokerman, mmccomas
Target Milestone: ---   
Target Release: 3.x   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-09 21:53:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
PreLifecycleHookNotCompletelyCleared none

Description Yadan Pei 2016-10-24 09:57:47 UTC 
Description of problem:
Go to DC edit page, first click 'advanced strategy options' to expand advanced options,then change strategy from Recreate to Rolling, select No(not to keep parameters),Timeout parameter value is cleared but Lifecycle Hooks are not cleared
If we didn't expand advanced options at first and change deployment strategy directly, all parameters will be cleared correctly

Version-Release number of selected component (if applicable):
v3.4.0.14

How reproducible:
Always

Steps to Reproduce:
1.Create app with DC strategy is Recreate
$ oc process -f https://raw.githubusercontent.com/openshift/rails-ex/master/openshift/templates/rails-postgresql.json |oc create -f -
2.Go to Applications -> Deployments -> rails-postgresql-example -> Actions -> Edit
3.First click advanced strategy options, Pre Lifecycle Hook is shown correctly
4.Change Strategy Type to Rolling, select No in dialog
5.Check parameter & value for Rolling strategy type

Actual results:
5.Timeout value is cleared, but Pre Lifecycle Hook is not cleared


Expected results:
5. Timeout and Pre Lifecycle Hook should both be cleared

Additional info:
Comment 1 Yadan Pei 2016-10-24 10:00:33 UTC 
Created attachment 1213424 [details]
PreLifecycleHookNotCompletelyCleared
Comment 2 openshift-github-bot 2016-11-02 17:53:34 UTC 
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/0accdd828e1c2a27dd1e12c664c1fb1374f5b34b
Bug 1388041 - Clear lifecycle hooks on strategy switch
Comment 3 Yadan Pei 2016-11-03 09:14:57 UTC 
Checked against openshift v1.4.0-alpha.0+90d8c62-1000


The fix has been merged, no matter "advanced options" is expanded or not, lifecycle hooks could be cleared successfully.

Could verify when change to ON_QA
Comment 4 Jessica Forrester 2016-11-03 14:26:47 UTC 
This bug is in the OCP product so it needs to wait to be moved to ON_QA until its been pulled into an OCP build. If this bug is moved to Origin we can move it to ON-QA sooner.
Comment 5 Yadan Pei 2016-11-04 03:16:33 UTC 
Sorry, i will change it back to Origin to get the fix sooner
Comment 6 Yadan Pei 2016-11-07 06:18:24 UTC 
Checked against v1.4.0-alpha.1+b81b382-59

It has been fixed, lifecycle hooks are cleared correctly

Move to VERIFIED