Bug 1388070

+++ This bug was initially created as a clone of Bug #1387207 +++

+++ This bug was initially created as a clone of Bug #1387152 +++

Description of problem:
=======================
When no operation is done on the gluster system, and we just have eventing enabled and a webhook listening on the other side, there are multiple times that we see VOLUME_SET events from every node of the cluster. If it is a 4node cluster, we see 4 such events.
{u'message': {u'name': u'help', u'options': [[u'']]}, u'event': u'VOLUME_SET', u'ts': 1476936891, u'nodeid': u'0dea52e0-8c32-4616-8ef8-16db16120eaa'}


I suppose it does not harm to see these, as they seem to be inconsequential. Nor have I been able to piece together a sequence of steps which trigger these. Hence raising a low-severity BZ as of now. Will update the BZ when I am able to gather any more information regarding the same.


Version-Release number of selected component (if applicable):
============================================================
3.8.4-2


How reproducible:
===================
Seen it 3 times


Additional info:
==================

[root@dhcp46-242 ~]# gluster peer status
Number of Peers: 3

Hostname: dhcp46-239.lab.eng.blr.redhat.com
Uuid: ed362eb3-421c-4a25-ad0e-82ef157ea328
State: Peer in Cluster (Connected)

Hostname: 10.70.46.240
Uuid: 72c4f894-61f7-433e-a546-4ad2d7f0a176
State: Peer in Cluster (Connected)

Hostname: 10.70.46.218
Uuid: 0dea52e0-8c32-4616-8ef8-16db16120eaa
State: Peer in Cluster (Connected)
[root@dhcp46-242 ~]# 
[root@dhcp46-242 ~]# 
[root@dhcp46-242 ~]# rpm -qa | grep gluster
glusterfs-debuginfo-3.8.4-1.el7rhgs.x86_64
glusterfs-fuse-3.8.4-2.el7rhgs.x86_64
glusterfs-cli-3.8.4-2.el7rhgs.x86_64
glusterfs-events-3.8.4-2.el7rhgs.x86_64
glusterfs-devel-3.8.4-2.el7rhgs.x86_64
glusterfs-api-devel-3.8.4-2.el7rhgs.x86_64
glusterfs-3.8.4-2.el7rhgs.x86_64
glusterfs-client-xlators-3.8.4-2.el7rhgs.x86_64
python-gluster-3.8.4-2.el7rhgs.noarch
glusterfs-ganesha-3.8.4-2.el7rhgs.x86_64
glusterfs-server-3.8.4-2.el7rhgs.x86_64
nfs-ganesha-gluster-2.3.1-8.el7rhgs.x86_64
glusterfs-libs-3.8.4-2.el7rhgs.x86_64
glusterfs-api-3.8.4-2.el7rhgs.x86_64
glusterfs-geo-replication-3.8.4-2.el7rhgs.x86_64
glusterfs-rdma-3.8.4-2.el7rhgs.x86_64
[root@dhcp46-242 ~]# 


[root@dhcp46-159 ~]# python webhook.py 
 * Running on http://10.70.46.159:9000/ (Press CTRL+C to quit)

##############################################################################################################
{u'message': {u'name': u'help', u'options': [[u'']]}, u'event': u'VOLUME_SET', u'ts': 1476936891, u'nodeid': u'0dea52e0-8c32-4616-8ef8-16db16120eaa'}
10.70.46.218 - - [15/Oct/2016 05:59:22] "POST /listen HTTP/1.1" 200 -
##############################################################################################################
{u'message': {u'name': u'help', u'options': [[u'']]}, u'event': u'VOLUME_SET', u'ts': 1476936891, u'nodeid': u'1e8967ae-51b2-4c27-907e-a22a83107fd0'}
10.70.46.242 - - [15/Oct/2016 05:59:22] "POST /listen HTTP/1.1" 200 -
##############################################################################################################
{u'message': {u'name': u'help', u'options': [[u'']]}, u'event': u'VOLUME_SET', u'ts': 1476936891, u'nodeid': u'72c4f894-61f7-433e-a546-4ad2d7f0a176'}
10.70.46.240 - - [15/Oct/2016 05:59:22] "POST /listen HTTP/1.1" 200 -
##############################################################################################################
{u'message': {u'name': u'help', u'options': [[u'']]}, u'event': u'VOLUME_SET', u'ts': 1476936891, u'nodeid': u'ed362eb3-421c-4a25-ad0e-82ef157ea328'}
10.70.46.239 - - [15/Oct/2016 05:59:22] "POST /listen HTTP/1.1" 200 -

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-10-20 05:19:54 EDT ---

This bug is automatically being proposed for the current release of Red Hat Gluster Storage 3 under active development, by setting the release flag 'rhgs‑3.2.0' to '?'. 

If this bug should be proposed for a different release, please manually change the proposed release flag.

--- Additional comment from Aravinda VK on 2016-10-20 05:46:45 EDT ---

Looks like `gluster volume set help` is run. {u'name': u'help', ..

I will handle the help case explicitly and send patch to not send Event when help is run.

--- Additional comment from Worker Ant on 2016-10-20 07:02:02 EDT ---

REVIEW: http://review.gluster.org/15685 (eventsapi: Fix sending event during volume set help) posted (#1) for review on master by Aravinda VK (avishwan)

--- Additional comment from Sweta Anandpara on 2016-10-21 04:47:16 EDT ---

Kindly note I had not run any 'gluster volume set help' command. When I explicitly run that command now in my cluster, I do see a similar event being generated. However, the event that I was seeing until now for which the bug was raised was not user-driven. It has to be something that is getting triggered internally. 
The above note is fyi.

Nevertheless, the patch will address the outcome. We are good there.

--- Additional comment from Worker Ant on 2016-10-24 05:15:32 EDT ---

COMMIT: http://review.gluster.org/15685 committed in master by Atin Mukherjee (amukherj) 
------
commit f31b3213e2a97259faa7dcae2354d2535732068b
Author: Aravinda VK <avishwan>
Date:   Thu Oct 20 16:26:27 2016 +0530

    eventsapi: Fix sending event during volume set help
    
    Event sent when `gluster volume set help` command is run
    with Volume name as "help" and empty options list
    
    With this patch, event sent only when volume set on a real volume
    
    BUG: 1387207
    Change-Id: Ia8785d6108cb86f7d89ecf9ea552df0334b41398
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/15685
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>