Bug 1388337

Summary: [userinterface_public_797]Should clear lifecycle hooks on CLI if we don't keep parameters during changing strategy from Recreate to Rolling
Product: OKD Reporter: Yadan Pei <yapei>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.xCC: aos-bugs, jforrest, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-09 21:53:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Yadan Pei 2016-10-25 07:06:53 UTC 
Description of problem:
When we change deployment strategy from Recreate to Rolling, select "No" then previous lifecyle hooks will be cleared and not shown on web console, but in Command Line, we could still see the lifecyle hooks when use 'oc describe dc <dc_name>'

Version-Release number of selected component (if applicable):
latest origin-web-console(latest commit is PR #715 from spadgett/metrics-pod-uid)

How reproducible:
Always

Steps to Reproduce:
1.Create app
# oc process -f https://raw.githubusercontent.com/openshift/rails-ex/master/openshift/templates/rails-postgresql.json |oc create -f -
2.Wait for #1 rails-postgresql-example build complete and #1 rails-postgresql-example deployment finish
3.Go to Applications -> Deployments -> rails-postgresql-example -> Actions -> Edit
4.Change Strategy Type to Rolling, select "No" in the dialogue
Timeout & Maximal Unavailable Pods & Maximal Surge Pods value are cleared
5.Click advanced strategy options
Update Period & Interval is also not set with value
No Pre Lifecycle Hook
No Post Lifecycle Hook
6.Set follow values and Save
Timeout: 500 seconds
Update Period:2 seconds
Interval: 2 seconds
Maximal Unavailable Pods:30%
Maximal Surge Pods: 30%
7.Check deployment hooks via CLI
# oc describe dc rails-postgresql-example


Actual results:
7. # oc describe dc rails-postgresql-example
....<snip>...
Strategy:	Rolling
  Pre-deployment hook (pod type, failure policy: Abort):
    Container:	rails-postgresql-example
    Command:	./migrate-database.sh
Pre-deployment hooks is still shown in output, indeed when changing Recreate to Rolling, all lifecycle hooks should be cleared if we select "No"

Expected results:
7. All lifecycle hooks should be cleared when we select "No" (means we don't keep parameter from Recreate strategy) in changing Recreate to Rolling
In step5, web console didn't show any lifecycle hooks after we selected "No"

Additional info:
Comment 1 openshift-github-bot 2016-10-25 14:55:23 UTC 
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/55a062028e08fb47af079b61b00069068a0eee56
Bug 1388337 - Clear lifecycle hooks when changing strategy from Recreate to Rolling
Comment 2 Yadan Pei 2016-10-27 03:36:31 UTC 
Checked against latest origin-web-console(latest commit is #746) with the same steps in "Steps to Reproduce"

Now on CLI, Lifecycle hooks are also cleared we we don't keep parameters during change strategy from Recreate to Rolling

Move to VERIFIED