Bug 1388354

Summary:	Memory Leaks in snapshot code path
Product:	[Community] GlusterFS	Reporter:	Avra Sengupta <asengupt>
Component:	snapshot	Assignee:	Avra Sengupta <asengupt>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs, rjoseph
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1386088	Environment:
Last Closed:	2016-11-29 09:36:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1386088
Bug Blocks:	1388350

Description Avra Sengupta 2016-10-25 07:29:10 UTC

+++ This bug was initially created as a clone of Bug #1386088 +++

Description of problem:
This talks about some obvious memory leaks, which can be cleaned up in the snapshot code path.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-10-18 03:31:31 EDT ---

REVIEW: http://review.gluster.org/15668 (snapshot: Fix for memory leaks in snapshot code path) posted (#1) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Worker Ant on 2016-10-18 08:21:11 EDT ---

REVIEW: http://review.gluster.org/15668 (snapshot: Fix for memory leaks in snapshot code path) posted (#2) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Worker Ant on 2016-10-20 04:39:30 EDT ---

REVIEW: http://review.gluster.org/15668 (snapshot: Fix for memory leaks in snapshot code path) posted (#3) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Worker Ant on 2016-10-25 03:16:49 EDT ---

COMMIT: http://review.gluster.org/15668 committed in master by Rajesh Joseph (rjoseph) 
------
commit 48a4c4e525665115f7e8c478d3bf51764427378d
Author: Avra Sengupta <asengupt>
Date:   Tue Oct 18 12:52:36 2016 +0530

    snapshot: Fix for memory leaks in snapshot code path
    
    Change-Id: Idc2cb16574d166e3c0ee1f7c3a485f1acb19fc8c
    BUG: 1386088
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/15668
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 1 Worker Ant 2016-10-25 07:30:10 UTC

REVIEW: http://review.gluster.org/15720 (snapshot: Fix for memory leaks in snapshot code path) posted (#1) for review on release-3.8 by Avra Sengupta (asengupt)

Comment 2 Worker Ant 2016-11-04 06:05:20 UTC

COMMIT: http://review.gluster.org/15720 committed in release-3.8 by Rajesh Joseph (rjoseph) 
------
commit 2328a1ca2cab00711efe8f256e532952280f6570
Author: Avra Sengupta <asengupt>
Date:   Tue Oct 18 12:52:36 2016 +0530

    snapshot: Fix for memory leaks in snapshot code path
    
    > Reviewed-on: http://review.gluster.org/15668
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Rajesh Joseph <rjoseph>
    
    (cherry picked from commit 48a4c4e525665115f7e8c478d3bf51764427378d)
    
    Change-Id: Idc2cb16574d166e3c0ee1f7c3a485f1acb19fc8c
    BUG: 1388354
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/15720
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 3 Niels de Vos 2016-11-29 09:36:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.6, please open a new bug report.

glusterfs-3.8.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2016-November/000217.html
[2] https://www.gluster.org/pipermail/gluster-users/