Bug 1388361

Summary: UI: C&U form validates even when Database Name field is empty
Product: Red Hat CloudForms Management Engine Reporter: Jan Krocil <jkrocil>
Component: UI - OPSAssignee: Aparna Karve <akarve>
Status: CLOSED CURRENTRELEASE QA Contact: Ilanit Stein <istein>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.7.0CC: cpelland, dajohnso, hkataria, istein, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:c&u:rhev
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1390728 (view as bug list) Environment:
Last Closed: 2017-06-12 17:51:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1390728    

Description Jan Krocil 2016-10-25 07:46:30 UTC 
Description of problem:
SSIA

Version-Release number of selected component (if applicable):
5.7.0.6

How reproducible:
Always

Steps to Reproduce:
1. Infra > Providers > Add
2. Type: RHEV
3. Fill in C&U creds but omit the Database Name Field
4. Validate

Actual results:
The 'Validate' button is active and validation works.

Expected results:
The 'Validate' button is inactive until the field contains data.

Additional info:
This field was added in 5.7 (Euwe), it was not present in 5.6 (Darga).
Comment 2 Harpreet Kataria 2016-10-26 03:04:07 UTC 
Aparna,

Can you please look into this one.

Thanks,
~Harpreet
Comment 3 CFME Bot 2016-10-27 00:21:21 UTC 
https://github.com/ManageIQ/manageiq/pull/12230
Comment 4 CFME Bot 2016-10-27 11:16:11 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/644654ab3278ac27479afede2e1478264cb1616f

commit 644654ab3278ac27479afede2e1478264cb1616f
Author:     Aparna Karve <akarve>
AuthorDate: Wed Oct 26 17:05:00 2016 -0700
Commit:     Aparna Karve <akarve>
CommitDate: Wed Oct 26 17:05:00 2016 -0700

    Make C&U Metrics Database a mandatory field for Validate
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1388361

 .../javascripts/controllers/ems_common/ems_common_form_controller.js     | 1 +
 1 file changed, 1 insertion(+)
Comment 5 CFME Bot 2016-11-01 15:41:07 UTC 
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/f6c519f289731a2ad066219ca2b99176d8fedf1f

commit f6c519f289731a2ad066219ca2b99176d8fedf1f
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Thu Oct 27 13:12:46 2016 +0200
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Tue Nov 1 11:39:57 2016 -0400

    Merge pull request #12230 from AparnaKarve/bz1388361_fix_validate_condition_on_rhev_db
    
    Make C&U Metrics Database a mandatory field for Validation
    (cherry picked from commit a01ec8fcc8c983f38025a7b630344c05b55399d9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1388361

 .../javascripts/controllers/ems_common/ems_common_form_controller.js     | 1 +
 1 file changed, 1 insertion(+)
Comment 7 Ilanit Stein 2017-05-07 08:55:45 UTC 
Verified on CFME-5.8.0.13/RHV-4.1.1.8.

When providing RHV C&U details, if Database Name field is empty, 
validate button is not active, and this field is mentioned as required.