Bug 1388372

Summary: [userinterface_public_797]Displaying issue on DC edit page for Custom strategy type
Product: OKD Reporter: Yadan Pei <yapei>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: medium    
Version: 3.xCC: aos-bugs, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-09 21:53:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Yadan Pei 2016-10-25 08:14:12 UTC
Description of problem:
1.Description about Image Name has redundant double quotation marks in the begining
2.Should remove the star(*) for Command field

Version-Release number of selected component (if applicable):
latest origin-web-console(latest commit is PR #715 from spadgett/metrics-pod-uid)

How reproducible:
Always

Steps to Reproduce:
1.Create a Rolling strategy DC
# oc create -f https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/deployment/rolling.json
2.Go to Applications -> Deployments -> hooks -> Actions -> Edit page
3.Change Strategy Type to "Custom"
4.Check fields and their description for Custom strategy

Actual results:
4.Image Name and Command are both shown as mandatory fields.
* Image Name
* Command
Environment Variables

Expected results:
4. According to doc https://docs.openshift.org/latest/dev_guide/deployments.html#custom-strategy, parameter 'command' is optional, although only filling Image Name and leaving Command blank could save the changes successfully, it's better to remove the star(*) before Command field

The description about "Image Name" has redundant double quotation marks in the begining
"An image that can carry out the deployment.

Additional info:

Comment 1 openshift-github-bot 2016-10-25 12:37:19 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/c50be77cd0be31608cfa3663ffc59252d690bb95
Bug 1388372 - Displaying issue on DC edit page for Custom strategy type

Comment 2 Yadan Pei 2016-11-01 05:46:24 UTC
Checked against latest origin-web-console(latest commit is 34067a1) 

Command is shown as optional parameter
Description about "Image Name" is shown well

Move to VERIFIED