Bug 1388378 (CVE-2016-8618)

Summary: CVE-2016-8618 curl: Double-free in curl_maprintf
Product: [Other] Security Response Reporter: Andrej Nemec <anemec>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: bmcclain, bodavis, cfergeau, csutherl, dbhole, dblechte, eedri, erik-fedora, gzaronik, hhorak, jclere, jorton, kanderso, kdudka, lgao, lsurette, luhliari, mbabacek, mgoldboi, michal.skrivanek, mike, mturk, myarboro, omajid, paul, rh-spice-bugs, rwagner, security-response-team, sherold, slawomir, srevivo, twalsh, weli, ykaul
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: curl 7.51.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-08 03:00:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1390894, 1390895, 1390896    
Bug Blocks: 1388393    
Attachments:
Description Flags
Upstream patch none

Description Andrej Nemec 2016-10-25 08:21:00 UTC
The libcurl API function called `curl_maprintf()` can be tricked into doing a
double-free due to an unsafe `size_t` multiplication, on systems using 32 bit
`size_t` variables. The function is also used internallty in numerous
situations.

The function doubles an allocated memory area with realloc() and allows the
size to wrap and become zero and when doing so realloc() returns NULL *and*
frees the memory - in contrary to normal realloc() fails where it only returns
NULL - causing libcurl to free the memory *again* in the error path.

Systems with 64 bit versions of the `size_t` type are not affected by this
issue.

This behavior is triggable using the publicly exposed function.

External References:

https://curl.haxx.se/docs/adv_20161102D.html

Comment 1 Andrej Nemec 2016-10-25 08:56:11 UTC
Created attachment 1213773 [details]
Upstream patch

Comment 2 Adam Mariš 2016-11-02 08:26:59 UTC
Created curl tracking bugs for this issue:

Affects: fedora-all [bug 1390894]

Comment 3 Adam Mariš 2016-11-02 08:27:12 UTC
Created mingw-curl tracking bugs for this issue:

Affects: fedora-all [bug 1390895]
Affects: epel-7 [bug 1390896]

Comment 6 errata-xmlrpc 2018-08-16 16:07:18 UTC
This issue has been addressed in the following products:

  Red Hat JBoss Core Services

Via RHSA-2018:2486 https://access.redhat.com/errata/RHSA-2018:2486

Comment 7 errata-xmlrpc 2018-11-13 08:32:50 UTC
This issue has been addressed in the following products:

  Red Hat Software Collections for Red Hat Enterprise Linux 6
  Red Hat Software Collections for Red Hat Enterprise Linux 7
  Red Hat Software Collections for Red Hat Enterprise Linux 7.4 EUS
  Red Hat Software Collections for Red Hat Enterprise Linux 7.5 EUS
  Red Hat Software Collections for Red Hat Enterprise Linux 7.6 EUS

Via RHSA-2018:3558 https://access.redhat.com/errata/RHSA-2018:3558