Bug 1388461
| Summary: | [Eventing]: BRICK_DISCONNECTED events seen when a tier volume is stopped | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Atin Mukherjee <amukherj> |
| Component: | glusterd | Assignee: | Atin Mukherjee <amukherj> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.9 | CC: | amukherj, bsrirama, bugs, kaushal, rhs-bugs, sanandpa, storage-qa-internal, vbellur |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.9.1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1387652 | Environment: | |
| Last Closed: | 2017-03-08 10:22:32 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1387652 | ||
| Bug Blocks: | 1387544 | ||
|
Description
Atin Mukherjee
2016-10-25 12:19:31 UTC
REVIEW: http://review.gluster.org/15722 (glusterd: use GF_BRICK_STOPPING as intermediate brickinfo->status state) posted (#1) for review on release-3.9 by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/15722 committed in release-3.9 by Atin Mukherjee (amukherj) ------ commit 2b5f080ba39ff0a7e2b5c3bc554f5680cf925858 Author: Atin Mukherjee <amukherj> Date: Fri Oct 21 18:27:45 2016 +0530 glusterd: use GF_BRICK_STOPPING as intermediate brickinfo->status state On a volume stop trigger glusterd issues a brick-op to terminate the brick process during brick-op phase , however in the commit-op glusterd once again tries to kill the same process if it exists and then mark the brickinfo->status flag to GF_BRICK_STOPPED. In the former case, if brick is successfully killed there is a possibility that GlusterD will receive RPC_CLNT_DISCONNECT from the said brick process before even the commit op phase is executed and hence by that time brickinfo->status will still be set to GF_BRICK_STARTED. BRICK_DISCONNECT event should be only sent if a brick has been killed and not through a volume stop/remove brick trigger, however due to this trace, this event is also sent out on a volume stop. Fix is to introduce an intermediate state GF_BRICK_STOPPING which can be used to mark the brick status at brick op phase of volume stop/remove brick to avoid sending spurious BRICK_DISCONNECT events on a volume stop trigger. >Reviewed-on: http://review.gluster.org/15699 >Smoke: Gluster Build System <jenkins.org> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.org> >Reviewed-by: Kaushal M <kaushal> Change-Id: Ieed4450e1c988715e0f9958be44faa6b14be81e1 BUG: 1388461 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/15722 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report. glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html [2] https://www.gluster.org/pipermail/gluster-users/ |